Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752637AbcCAJNb (ORCPT ); Tue, 1 Mar 2016 04:13:31 -0500 Received: from mail-db3on0083.outbound.protection.outlook.com ([157.55.234.83]:43014 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750933AbcCAJNY (ORCPT ); Tue, 1 Mar 2016 04:13:24 -0500 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; Subject: Re: [PATCHv7 2/3] IB/core: added support to use rdma cgroup controller To: Parav Pandit , , , , , , , , , , , References: <1456668821-25799-1-git-send-email-pandit.parav@gmail.com> <1456668821-25799-3-git-send-email-pandit.parav@gmail.com> CC: , , , , , , , From: Haggai Eran Message-ID: <56D55CE6.7030103@mellanox.com> Date: Tue, 1 Mar 2016 11:12:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456668821-25799-3-git-send-email-pandit.parav@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.52.254] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CPI:193.47.165.134;IPV:NLI;CTRY:IL;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(189002)(24454002)(479174004)(199003)(76176999)(189998001)(47776003)(1096002)(11100500001)(36756003)(81156008)(6116002)(586003)(3846002)(33656002)(64126003)(5008740100001)(1220700001)(77096005)(2950100001)(4001350100001)(6806005)(5001770100001)(65806001)(2906002)(230700001)(4326007)(50466002)(2201001)(50986999)(5004730100002)(92566002)(54356999)(83506001)(87266999)(106466001)(23746002)(86362001)(87936001)(65816999)(5001960100003)(3940600001)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB1788;H:mtlcas13.mtl.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM1FFO11FD045;1:d7eMMfY2EreQuAHErPvOwEjOrKhi8KBvdDGfzvyGlo122cXhpGpTeD/+0JWRrxZtUcAljpFZdURh9hpRv07Yk8Wff/pQU+yiIyewrWsfeqApaJYf2Jie4DHY32QEoJrhJbOjH+qTmGM7w3SDpTAtX0+oFB+1SsUZqYRC0dX8mueybUHwl2WdZUM1iXJ6xdYSDj0aslYkIXqnDQ/SF25m1Mbt/LqoKIDdOiKp6j8lZtj2HPkMAX4WQVOvwKGxdCaugPkkvBOto4jnujrChKtn/b81oYcnV0EPammlYO+zQIS1+z1E8Jco/fsuUCkDOEa9Z7PQRT8R6ADxxPT2DLA3y4Dfdziv+ynLPIb0PsliYaS94HOzSJ2Lo2BiumxQwtSYnn2KfJ26UMuopuzH/Mo3fCUhoeSnE05jW3bg1+20JS7fmZ83xtffYDSEfIE4cQjsOhPyyYXVFTJcLSLteafElrnSEQQ5K68bKcE8pH8P93nTfhyFL2hpQLaRQrqcxTU0 X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1788;2:NA5eH8u69yZxRKMkeuN2UxI9D/Yv42Zl93zt53GWCB+MKR8n+PH6Lj4i3Y7UpWlJ3M/OSaB6wjuHpayS/6ffe+aI31Bj0C7ABxi2TOjKrhM7xT/DaWWJyWSBV1O+kmviwog8uHzenYC8mhrxKp8Zjw==;3:6rFp7lB7MH6up368C/btOcOOBqzGbTmD4sfxYfO6u0+0Vs4c2SX3zz/Lv9HsAllOIQovTXmyo11M0xdCL69YsjgxO23ViKfeyyXWNFlZkxygMHVP6KVr3CqWErcSLF43pol0BfIe/yxqfh/sm6VYcKJuXbnkki4FKLzqWJldaPp5Ol9VEMcLoZ86xMkgsHvk3gGYnWH93FQLX7RV8PwZPg==;25:UMGS7Yz/uchkvamy4A1QXnayJ7n9y9WYWRvIy7KZX6fsanI8cyHJ0OPkdN9MgMFF/sqnnn+cIJ7rQS7oX0OzrbbYx2rp6c8u0WLDQgNx44pC8IuieTu6dP01XxGI04kMuCXuIT0lmhCmA4hlWr6aEr21FckI5XQYtX0NsBa5v2jIVQHNhk5N5954taJKAfPaoR3O/OGJ+HP2Ese/FlU9FCgpKIDNvMv1bLexd7cG8xhSdFyEKIS4gouQSI9+RMn6wYZgHXVh/Gr5pnm1HuvNsUWwIYimzDYd5aGSze07e+yF23WVRTxe9V6Efrlj08A3m0PxCdGKGOCaAKz8E9Lc8Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:HE1PR05MB1788; X-MS-Office365-Filtering-Correlation-Id: 88c5487c-5b14-47f9-04e3-08d341b1bb06 X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1788;20:KpLVnLnJxdSnFn2ozLWLSgURtq3YgCDibQqxssKi41NiXIMLKDPXrFB9F243pC4HTx4q9TpOTx4jZyLpdA5y357d64iLPp2b8Z/dckNtsLQjS1aKDagJmlA+GnATjZLPKMihJndqjLPSJpjxTX2nJqBd7pHBiDjjYf9Eqjqy/mBRnE8LXuVogRJlNJjggyMFFWI40bOyf4hU/vaALOWCxYqKBl1Hkqp867+2UIKleqtR0e/xEaaIBwTbMRb3z2gAO7oxlZXwGvN4x88BSXeufOtXi6zGNuGO4ERDg9oPokZBDriehnfYwhPXjb3FRN4qiASGnwbb8ZhJbEF2/a/gpP3mcTn20tY0MKvNG76wMdfq0zhwE/q3Vd0NWmpLj4a2lvNKZIosvL3yDXD3cCCiemtnGMr9/Rcg1QwUuHEtGoHfG+tZNhTkQ16V4vbBo7HvWObP92kfJNPNUjK186ihDZNapRBxch23xSzutJP5VtFZ/WI6/Ju6xubGJpid0rio X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13024025)(8121501046)(13018025)(13017025)(13015025)(5005006)(13023025)(3002001)(10201501046);SRVR:HE1PR05MB1788;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1788; X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1788;4:m6qQou0zSIE+bpCTqAjgfCMc21/b/JQ5QKiDrxUXjh9iiExPxRLaW73eDNDVnNYayMEGcS2vKnEyr0IFbgw0zXMnnIU+/PK6pCr51j+j88/jlh1IRJUJS5Sp78ZRq3jfJmRb5tml7rgx0spejwG44u2jn6G7UMCyX7RG8UWeOYMC8ymXRVc/XwjcFa0Qupb5lOUCD6NEvzkW/AHcWHEQZD5wOZcQ4HVNB1iKqqdi4WcvG3z2QwjRYwSCz/S9tUPhfMN6648no+4ckrZukDPzErpVTW7iUv7BoJlMBmLm4GfCpozgBWh+mXuvHffgl834ZOOCIyIp1z7R0DovnCGutmfVU74jY55ezQGnL5d0SjTYV92kkNonEHD1zDFb3etnavozAXAJLAwDkirtAWOGB3cfSKz/CjtasUNCLhIGq7dqgm9kwFXQ+aiX7BuYOaDfbpjyp1HqhtNdMaOkl9OdsQ== X-Forefront-PRVS: 086831DFB4 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR05MB1788;23:cWdyYdP4alE1g0uyfyp6JdV/D2HFQ2v/aOV3H?= =?Windows-1252?Q?YwxWHuB7e7zuJmBEaQesDmga+kTAuO7L9fZqN1ZIn7yxlRVHzTad9P2V?= =?Windows-1252?Q?OdoiP2dE8hw4lLF6TyEBtQeKNcLhd1jPy3Gba0Yq+BpFrSf8+b9V5TvM?= =?Windows-1252?Q?afUGGRk9uqeVWvSKlxzs8beaf31vrnna8EuK0NjdbvngOZ2GrVD06iNw?= =?Windows-1252?Q?9gNp3PRII3iKRJAWR/XLA+A4T+vWJB2QhQ7hOaFtQQaVA+ZgxdHPsBhO?= =?Windows-1252?Q?G5cAMJDGgBs8Kb9oCYugwVdADcRBPENAMXscGl6OzBLY/5wGV+Ww01yO?= =?Windows-1252?Q?nXyXeIr3UR5LXmNZ6+TKQszVURrzRj1fH0abwkP6ivanwMckSR+fmm9f?= =?Windows-1252?Q?KPe24ESs6L48QpEMpUetZLVuqIm7R9cL5/VQqGgV7QZTjjPSR/l7XYP1?= =?Windows-1252?Q?8XZeGEwnUtHr154KOZ2GOn55/oMkFFPw5tQ9A+wkrG8sP6O6GnxeIvub?= =?Windows-1252?Q?cjFmzNQI/+pYhKJA8kzctp51WaCEvPxt9fbKc3Mfyqerp3LQx+jzXaeR?= =?Windows-1252?Q?ci9ktD2M123ipyasKsHWBeUCrQJn3bCjeZxxyn7PBoAKDMxHptw+PUfr?= =?Windows-1252?Q?BmMExeTyvNs3v0XGAQzMonHCqsP4CeA2AuCPJ5bhTg8jE4rP/Z0bjZ2L?= =?Windows-1252?Q?AsAfnPchKgHNJJN6SN1poVPkeQJw837m/B7uxkcm62XNg8h9X4RpqxRa?= =?Windows-1252?Q?GK4zjGfHE7YPgpHQZz1xtj4x15J++JE1dI6nQjKl00vHxH5cI7qLKLUk?= =?Windows-1252?Q?lsb+c3zG8zIJXtDHenueuJDHXWqed+kcqmJ/9k+Ypj+8gfSODHMHzpeY?= =?Windows-1252?Q?KjNBxxwmUJOIXPQ1cF5Eov0DQDtKtmnTXHScBjX/TX0MRyV+iCyaB3cb?= =?Windows-1252?Q?v2PA1Ft45YqctuZfxklpptp5yEF9JWSYxrzQESJJ099OTM5DMDpOYC7A?= =?Windows-1252?Q?xgNZC/8L4WNEfNpickLbrefAAG7/m+rPnHdAgfWKLFM+90YS8IO/YoRy?= =?Windows-1252?Q?BBjmQ+5bAASiKip4RgK3q7eiW3MR1MqIb+szn2GUVSuEhcXOSe9G8mH6?= =?Windows-1252?Q?jxovgJHoY9Fk3p6ihHIRQyJzDCfbngC+QJ6buSVfEYgeRoif/pY4qtO/?= =?Windows-1252?Q?Drk/XOiXsr3n29oNfsX6E696RapKM+8+r3/g7o0I6jjSkNppoXr9sNW/?= =?Windows-1252?Q?biOO5R5gKyFiImCcNU5eSjScdl8NqJLmQf9bUE=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB1788;5:j3enn3+NQAg3oVb87saTwWemdoVQc1ZZPsoJeT+rs+7kM/1X1m4Naf50Ug8Ld3trgW+R+wLOvpVdLJ5yErL15D0n5gwm8aKBMRtR3RwJB3Gc6zBseSzmGIETl1IX9jdqdnY9Pb/bIHqJe0f8Q2BYgw==;24:mni9yumjcHy4+S7/dDqnmBC/e4uiocgmceihA9uAp/o4SvsVna7NfbGgjTNfUPiZs3i0F+ZnqBVZruOzCqljeZFF98EL8juM+xwhtU96qyI= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2016 09:13:18.7442 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1788 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 608 Lines: 16 On 28/02/2016 16:13, Parav Pandit wrote: > diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c > index 00da80e..54ea8ce 100644 > --- a/drivers/infiniband/core/device.c > +++ b/drivers/infiniband/core/device.c > @@ -343,28 +343,38 @@ int ib_register_device(struct ib_device *device, > > ret = read_port_immutable(device); > if (ret) { > - printk(KERN_WARNING "Couldn't create per port immutable data %s\n", > - device->name); > + pr_warn("Couldn't create per port immutable data %s\n", > + device->name); > goto out; This change doesn't belong in the patch.