Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752803AbcCAJWV (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Mar 2016 04:22:21 -0500
Received: from mail-wm0-f45.google.com ([74.125.82.45]:36836 "EHLO
	mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751870AbcCAJWS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Mar 2016 04:22:18 -0500
MIME-Version: 1.0
In-Reply-To: <56D55CE6.7030103@mellanox.com>
References: <1456668821-25799-1-git-send-email-pandit.parav@gmail.com>
	<1456668821-25799-3-git-send-email-pandit.parav@gmail.com>
	<56D55CE6.7030103@mellanox.com>
Date: Tue, 1 Mar 2016 14:52:15 +0530
Message-ID: <CAG53R5UrM7WAuamCEynDRKV0YMJsJUe=SEYfTrueQD0rtx71bA@mail.gmail.com>
Subject: Re: [PATCHv7 2/3] IB/core: added support to use rdma cgroup controller
From: Parav Pandit <pandit.parav@gmail.com>
To: Haggai Eran <haggaie@mellanox.com>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
        Tejun Heo <tj@kernel.org>, lizefan@huawei.com,
        Johannes Weiner <hannes@cmpxchg.org>,
        Doug Ledford <dledford@redhat.com>, Liran Liss <liranl@mellanox.com>,
        "Hefty, Sean" <sean.hefty@intel.com>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Jonathan Corbet <corbet@lwn.net>, james.l.morris@oracle.com,
        serge@hallyn.com, Or Gerlitz <ogerlitz@mellanox.com>,
        Matan Barak <matanb@mellanox.com>, raindel@mellanox.com,
        akpm@linux-foundation.org, linux-security-module@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 947
Lines: 21

On Tue, Mar 1, 2016 at 2:42 PM, Haggai Eran <haggaie@mellanox.com> wrote:
> On 28/02/2016 16:13, Parav Pandit wrote:
>> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
>> index 00da80e..54ea8ce 100644
>> --- a/drivers/infiniband/core/device.c
>> +++ b/drivers/infiniband/core/device.c
>> @@ -343,28 +343,38 @@ int ib_register_device(struct ib_device *device,
>>
>>       ret = read_port_immutable(device);
>>       if (ret) {
>> -             printk(KERN_WARNING "Couldn't create per port immutable data %s\n",
>> -                    device->name);
>> +             pr_warn("Couldn't create per port immutable data %s\n",
>> +                     device->name);
>>               goto out;
>
> This change doesn't belong in the patch.
I agree, but few warnings are with pr_warn and few with printk just
make code look uneven.
So I changed printk to pr_warn in same function instead of spinning
complete new patch.