Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753358AbcCAMIS (ORCPT ); Tue, 1 Mar 2016 07:08:18 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:60725 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752301AbcCAMIR (ORCPT ); Tue, 1 Mar 2016 07:08:17 -0500 Date: Tue, 1 Mar 2016 04:08:14 -0800 From: Christoph Hellwig To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, cmaiolino@redhat.com, darrick.wong@oracle.com, namjae.jeon@samsung.com, bfoster@redhat.com, sandeen@sandeen.net, xfs@oss.sgi.com, billodo@redhat.com Subject: Re: [PATCH] xfs: remove impossible condition Message-ID: <20160301120814.GA5217@infradead.org> References: <1456404237-18169-1-git-send-email-luisbg@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456404237-18169-1-git-send-email-luisbg@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 397 Lines: 11 On Thu, Feb 25, 2016 at 12:43:57PM +0000, Luis de Bethencourt wrote: > bp_release is set to 0 just before the breakpoint of the for loop before > the conditional check (in line 458). The other breakpoint is a goto that > skips the dead code. Yes, this looks correct: Reviewed-by: Christoph Hellwig The whole code around this is rather grotty and could use some more work, though..