Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753449AbcCANUu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Mar 2016 08:20:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53109 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751125AbcCANUt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Mar 2016 08:20:49 -0500
Date: Tue, 1 Mar 2016 10:20:47 -0300
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Aaro Koskinen <aaro.koskinen@nokia.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Lukas Wunner <lukas@wunner.de>, Jiri Olsa <jolsa@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tools build: use .s extension for preprocessed assembler
 code
Message-ID: <20160301132047.GA2524@redhat.com>
References: <1454263140-19670-1-git-send-email-yamada.masahiro@socionext.com>
 <CAK7LNAT0YCHbh7CfWKG1bZiJCXNXk7Jv6sdQz_9Sa6OG5zScrg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNAT0YCHbh7CfWKG1bZiJCXNXk7Jv6sdQz_9Sa6OG5zScrg@mail.gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1471
Lines: 54

Em Tue, Mar 01, 2016 at 02:31:10PM +0900, Masahiro Yamada escreveu:
> Hi Arnaldo,
> 
> Do you have any comment on this patch?

Sorry for the delay, I saw this patch, found no problems with it but was
waiting for Jiri's Ack, which he provided today, applying, thanks.

- Arnaldo
 
> (I hope I am addressing myself to a right person.
> "git log --pretty=fuller tools/build/Makefile.build" showed that
> several patches in this area had been applied by you.)
> 
> 
> Thanks,
> 
> 
> 2016-02-01 2:59 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > The "man gcc" says .i extension represents the file is C source code
> > that should not be preprocessed.  Here, .s should be used.
> >
> > For clarification,
> >   .c  ---(preprocess)--->  .i
> >   .S  ---(preprocess)--->  .s
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> >  tools/build/Makefile.build | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> > index 4a96473..ee566e8 100644
> > --- a/tools/build/Makefile.build
> > +++ b/tools/build/Makefile.build
> > @@ -85,7 +85,7 @@ $(OUTPUT)%.i: %.c FORCE
> >         $(call rule_mkdir)
> >         $(call if_changed_dep,cc_i_c)
> >
> > -$(OUTPUT)%.i: %.S FORCE
> > +$(OUTPUT)%.s: %.S FORCE
> >         $(call rule_mkdir)
> >         $(call if_changed_dep,cc_i_c)
> >
> > --
> > 1.9.1
> >
> 
> 
> 
> -- 
> Best Regards
> Masahiro Yamada