Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753670AbcCANXs (ORCPT ); Tue, 1 Mar 2016 08:23:48 -0500 Received: from lists.s-osg.org ([54.187.51.154]:53177 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbcCANXr (ORCPT ); Tue, 1 Mar 2016 08:23:47 -0500 Message-ID: <56D597D5.3040002@osg.samsung.com> Date: Tue, 01 Mar 2016 13:23:33 +0000 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Christoph Hellwig CC: linux-kernel@vger.kernel.org, cmaiolino@redhat.com, darrick.wong@oracle.com, namjae.jeon@samsung.com, bfoster@redhat.com, sandeen@sandeen.net, xfs@oss.sgi.com, billodo@redhat.com Subject: Re: [PATCH] xfs: remove impossible condition References: <1456404237-18169-1-git-send-email-luisbg@osg.samsung.com> <20160301120814.GA5217@infradead.org> In-Reply-To: <20160301120814.GA5217@infradead.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 742 Lines: 22 On 01/03/16 12:08, Christoph Hellwig wrote: > On Thu, Feb 25, 2016 at 12:43:57PM +0000, Luis de Bethencourt wrote: >> bp_release is set to 0 just before the breakpoint of the for loop before >> the conditional check (in line 458). The other breakpoint is a goto that >> skips the dead code. > > Yes, this looks correct: > > Reviewed-by: Christoph Hellwig > > The whole code around this is rather grotty and could use some more > work, though.. > Thanks for the review Christoph! If you have some specific things in mind that I could fix in the code around this, I am happy to add it to my ToDo list. Or I can continue reading it and let you know of anything I see, so you can confirm before I try to fix it. Regards, Luis