Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754458AbcCAO5c (ORCPT ); Tue, 1 Mar 2016 09:57:32 -0500 Received: from host.buserror.net ([209.198.135.123]:39991 "EHLO host.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754445AbcCAO53 (ORCPT ); Tue, 1 Mar 2016 09:57:29 -0500 Message-ID: <1456844240.5360.65.camel@buserror.net> From: Scott Wood To: Alessio Igor Bogani Cc: Kumar Gala , linuxppc-dev@lists.ozlabs.org, LKML Date: Tue, 01 Mar 2016 08:57:20 -0600 In-Reply-To: References: <1456397825-1786-1-git-send-email-alessio.bogani@elettra.eu> <1456397825-1786-2-git-send-email-alessio.bogani@elettra.eu> <1456785480.5360.60.camel@buserror.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 75.72.173.242 X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Subject: Re: [RFC PATCH v1 2/2] powerpc/86xx: Introduce and use common dtsi X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on host.buserror.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 614 Lines: 23 On Tue, 2016-03-01 at 15:55 +0100, Alessio Igor Bogani wrote: > Scott, > > On 29 February 2016 at 23:38, Scott Wood wrote: > [...] > > > > > +&pci0 { > > > + compatible = "fsl,mpc8641-pcie"; > > > + device_type = "pci"; > > > + #size-cells = <2>; > > > + #address-cells = <3>; > > > + bus-range = <0x0 0xff>; > > > + clock-frequency = <33333333>; > > > > The clock frequency of PCI Express is not 33 MHz. > > A lot of dtsi files into fsl directory have got that value! Well, they shouldn't. :-P This isn't the first time I've told someone to take that out. -Scott