Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932091AbcCAP6c (ORCPT ); Tue, 1 Mar 2016 10:58:32 -0500 Received: from g4t3426.houston.hp.com ([15.201.208.54]:21223 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753734AbcCAP6a (ORCPT ); Tue, 1 Mar 2016 10:58:30 -0500 Message-ID: <1456850284.15454.23.camel@hpe.com> Subject: Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to comply ACPI 6.1 From: Toshi Kani To: "Moore, Robert" , "rjw@rjwysocki.net" , "Williams, Dan J" Cc: "Zheng, Lv" , "elliott@hpe.com" , "linux-nvdimm@lists.01.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@acpica.org" Date: Tue, 01 Mar 2016 09:38:04 -0700 In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37E44D64B@ORSMSX110.amr.corp.intel.com> References: <1456178130-26468-1-git-send-email-toshi.kani@hpe.com> <1456178130-26468-2-git-send-email-toshi.kani@hpe.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37E44D64B@ORSMSX110.amr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.4 (3.18.4-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1483 Lines: 36 On Tue, 2016-03-01 at 15:13 +0000, Moore, Robert wrote: > > > -----Original Message----- > > From: Toshi Kani [mailto:toshi.kani@hpe.com] > > Sent: Monday, February 22, 2016 1:55 PM > > To: rjw@rjwysocki.net; Williams, Dan J > > Cc: Moore, Robert; Zheng, Lv; elliott@hpe.com; linux-nvdimm@lists.01.or > > g; > > linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; > > devel@acpica.org; Toshi Kani > > Subject: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to > > comply ACPI 6.1 > > > > ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure as > > follows. > >  - Valid Fields, Manufacturing Location, and Manufacturing Date > >    are added from reserved range.  No change in the structure size. > >  - IDs defined as SPD values are arrays of bytes.  The spec > >    clarified that they need to be represented as arrays of bytes > >    as well. > > > > This patch makes the following changes to support this update. > >  - Change 'struct acpi_nfit_control_region' to reflect the update. > >    SPD IDs are defined as arrays of bytes, so that they can be > >    treated in the same way regardless of CPU endianness and are > >    not miss-treated as little-endian numeric values. > > > I don't think we are going to start changing the ACPI tables defined in > the ACPICA headers because of this. We do in fact have macros for this > purpose. Can you elaborate what macros you suggest to use for this purpose? Thanks, -Toshi