Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751145AbcCAQaZ (ORCPT ); Tue, 1 Mar 2016 11:30:25 -0500 Received: from mail-yw0-f193.google.com ([209.85.161.193]:35554 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbcCAQaV (ORCPT ); Tue, 1 Mar 2016 11:30:21 -0500 Date: Tue, 1 Mar 2016 11:30:18 -0500 From: Tejun Heo To: Vladimir Davydov Cc: Andrew Morton , Johannes Weiner , Michal Hocko , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] cgroup: reset css on destruction Message-ID: <20160301163018.GE3965@htj.duckdns.org> References: <69629961aefc48c021b895bb0c8297b56c11a577.1456830735.git.vdavydov@virtuozzo.com> <92b11b89791412df49e73597b87912e8f143a3f7.1456830735.git.vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92b11b89791412df49e73597b87912e8f143a3f7.1456830735.git.vdavydov@virtuozzo.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 388 Lines: 15 On Tue, Mar 01, 2016 at 02:13:13PM +0300, Vladimir Davydov wrote: > @@ -5138,6 +5138,8 @@ static void kill_css(struct cgroup_subsys_state *css) > * See seq_css() for details. > */ > css_clear_dir(css, NULL); > + if (css->ss->css_reset) > + css->ss->css_reset(css); I think the better spot for this is in offline_css() right before ->css_offline() is called. Thanks. -- tejun