Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751559AbcCARIp (ORCPT ); Tue, 1 Mar 2016 12:08:45 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:34755 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbcCARIo (ORCPT ); Tue, 1 Mar 2016 12:08:44 -0500 From: Amitkumar Karwar To: Marcel Holtmann CC: BlueZ development , Nishant Sarmukadam , "linux-kernel@vger.kernel.org" , Cathy Luo , Ganapathi Bhat Subject: RE: [PATCH v2] Bluetooth: hci_uart: Support firmware download for Marvell Thread-Topic: [PATCH v2] Bluetooth: hci_uart: Support firmware download for Marvell Thread-Index: AQHRa7W9CVyXd2Ca9UCxy6Qr7P32M59E4XNg Date: Tue, 1 Mar 2016 17:08:38 +0000 Message-ID: References: <1455627233-6928-1-git-send-email-akarwar@marvell.com> <273F0F9E-5E5C-4F21-A503-027A83B7F61E@holtmann.org> In-Reply-To: <273F0F9E-5E5C-4F21-A503-027A83B7F61E@holtmann.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: multipart/mixed; boundary="_002_b7d52fc731a14f28b207ccf4470f6a43SCEXCH04marvellcom_" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-01_09:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1603010319 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3273 Lines: 64 --_002_b7d52fc731a14f28b207ccf4470f6a43SCEXCH04marvellcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Marcel, > > + > > + kfree(skb); > > + BT_INFO("leave dnld_fw\n"); > > + > > + return ret; > > +} >=20 > I think it would help if you explain on how the firmware download for > your UART devices work. I have the feeling we need a bit better core > handling in this case and not end up hacking it in this way. >=20 > > + I have explained our firmware download mechanism in attached text file. I will shortly send V3 patch which address your review comments. Let me kno= w if you have any suggestions. Regards, Amit --_002_b7d52fc731a14f28b207ccf4470f6a43SCEXCH04marvellcom_ Content-Type: text/plain; name="Marvell_UART_FW_download.txt" Content-Description: Marvell_UART_FW_download.txt Content-Disposition: attachment; filename="Marvell_UART_FW_download.txt"; size=1592; creation-date="Tue, 01 Mar 2016 15:47:40 GMT"; modification-date="Tue, 01 Mar 2016 15:47:40 GMT" Content-Transfer-Encoding: base64 RmlybXdhcmUgZG93bmxvYWQgd29ya3Mgb24gdGhlIGZlZWRiYWNrIG1lY2hhbmlzbSBiZXR3ZWVu CmRyaXZlciBhbmQgdGhlIGRldmljZS4gRm9yIGV2ZXJ5IGNodW5rIG9mIGZpcm13YXJlIGRvd25s b2FkZWQsCnRoZSBkZXZpY2Ugd2lsbCBzZW5kIGFuIEFDSyBhbmQgYXBwZW5kIHRoZSBuZXh0IGxl bmd0aCAoaW4gYnl0ZXMpCnRvIGJlIGRvd25sb2FkZWQuIERyaXZlciB3aWxsIGRlY29kZSB0aGlz IGluZm8gYW5kIGRvd25sb2FkIGJ5dGVzCmFjY29yZGluZ2x5LgoKT24gcG93ZXIgb24sIHRoZSBk ZXZpY2Ugc3RhcnRzIHNlbmRpbmcgYmVsb3cgaGVhcnRiZWF0IHNlcXVlbmNlOgoKaGVhcnRiZWF0 ICg1IGJ5dGVzKSA6IHxIRFJ8WFh8WFh8WFh8WFh8CgpIRFIgMHhBNTogSGVhZGVyIGluZGljYXRp bmcgQUNLCgpJZiBIRFIgaXMgQUNLKDB4QTUpIHRoZW4gcmVzdCBvZiB0aGUgYnl0ZXMgYXJlIGRl Y29kZWQgYXMgYmVsb3c6Cgp8MHhBNXxMMXxMMnxDTDF8Q0wyfAoKTDEgOiBMU0Igb2YgbGVuZ3Ro IG9mIHRoZSBmaXJtd2FyZSBieXRlcyB0byBiZSBzZW50IGZyb20gdGhlIGhvc3QKTDIgOiBNU0Ig b2YgbGVuZ3RoIG9mIHRoZSBmaXJtd2FyZSBieXRlcyB0byBiZSBzZW50IGZyb20gdGhlIGhvc3QK Q0wxOiBDb21wbGVtZW50IG9mIEwxCkNMMjogQ29tcGxlbWVudCBvZiBMMgoKRHJpdmVyIHdpbGwg ZGVjb2RlIHRoZSBsZW5ndGggZnJvbSBhYm92ZSBzZXF1ZW5jZSBhbmQgZG93bmxvYWQgCmJ5dGVz IGFjY29yZGluZ2x5LiBEZXZpY2Ugd2lsbCBhY2tub3dsZWRnZSB0aGUgc2FtZSBhbmQgYXBwZW5k CmxlbnRoIHRvIGJlIGRvd25sb2FkZWQgaW4gbmV4dCB0cmFuc21pc3Npb24uCgpIRFIgMHhBQTog SGVhZGVyIGluZGljYXRpbmcgY2hpcCBpZCBhbmQgcmV2aXNpb24KSWYgSERSIGlzIGNoaXAgaW5m bygweEFBKSB0aGVuIHJlc3Qgb2YgdGhlIGJ5dGVzIGFyZSBkZWNvZGVkIGFzIGJlbG93OgoKfDB4 QTV8Q0hJUF9JRHxDSElQX1JFVnxDQ0hJUF9JRHxDQ0hJUF9SRVZ8CgpDSElQIElEICA6IElkIG9m IHRoZSBjaGlwCkNISVBfUkVWIDogQ2hpcCByZXZpc2lvbgpDQ0hJUF9JRCA6IENvbXBsZW1lbnQg b2YgY2hpcCBpZApDQ0hJUF9SRVY6IENvbXBsZW1lbnQgb2YgY2hpcCByZXZpc2lvbgoKVGhlIGRl dmljZSB3aWxsIHN0YXJ0IHNlbmRpbmcgYWJvdmUgMHhBQSBzZXF1ZW5jZSBvbmNlIGhlbHBlcgpm aWxlIGdldHMgZG93bmxvYWRlZC4gSGVscGVyIGZpbGUgaXMgbmVlZGVkIHRvIG1ha2UgZGV2aWNl Cndvcmsgd2l0aCBoaWdoZXIgYmF1ZCByYXRlLgoKQWZ0ZXIgZG93bmxvZGluZyB0aGUgaGVscGVy LCBkcml2ZXIgd2lsbCBjaGFuZ2UgdGhlIGJhdWRyYXRlCmluIGRldmljZSBhbmQgc3RhcnQgZG93 bmxvYWRpbmcgdGhlIGZpcm13YXJlLiBUaGlzIHJlZHVjZXMgdGhlCnRpbWUgbmVlZGVkIHRvIGRv d25sb2FkIHRoZSBmaXJtd2FyZS4gRm9yIGVhY2ggYmF1ZCByYXRlIHRoZXJlCmV4aXN0cyBkaWZm ZXJlbnQgaGVscGVyIGZpbGVzLiBJbiB0aGUgZ2l2ZW4gcGF0Y2ggd2UgYXJlCnVzaW5nIGhlbHBl ciBmaWxlIHdoaWNoIGVuYWJsZWQgZmlybXdhcmUgZG93bmxvYWQgaW4gM01CIHNwZWVkLgo= --_002_b7d52fc731a14f28b207ccf4470f6a43SCEXCH04marvellcom_--