Date: Tue, 1 Mar 2016 13:20:06 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Michele Di Giorgio <michele.digiorgio@arm.com>
Cc: linux-pm@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Javi Merino <javi.merino@arm.com>, linux-kernel@vger.kernel.org,
        Punit Agrawal <punit.agrawal@arm.com>,
        Eduardo Valentin <edubezval@gmail.com>
Subject: Re: [PATCH] thermal: trace: migrating thermal traces to use
 TRACE_DEFINE_ENUM() macros
Message-ID: <20160301132006.1cda539c@gandalf.local.home>
In-Reply-To: <1456853934-24715-1-git-send-email-michele.digiorgio@arm.com>
References: <1456853934-24715-1-git-send-email-michele.digiorgio@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1134
Lines: 30

On Tue,  1 Mar 2016 17:38:54 +0000
Michele Di Giorgio <michele.digiorgio@arm.com> wrote:

> Userspace tools are not aware of how to convert the enums provided by
> the tracepoints to their corresponding strings.
> 
> Adding TRACE_DEFINE_ENUM() macros allows to make the enums available
> to userspace to let the tools know what those enum values represent.
> 
> In particular, for thermal zone trip types what we obtained before was
> something like:
> 
> kworker/1:1-460   [001]   320.372732: thermal_zone_trip:    thermal_zone=soc
> 				id=0 trip=1 trip_type=1
> 
> Unfortunately, userspace tools do not know how to convert enum values to
> strings and as a consequence they can only forward the enum value to the
> output. By using TRACE_DEFINE_ENUM() macros for thermal traces we get the
> following trace line:
> 
> kworker/1:1-460   [001]   320.372732: thermal_zone_trip:    thermal_zone=soc
> 				id=0 trip=1 trip_type=PASSIVE
> 
> Userspace tools are now able to better understand the meaning of the trip_type
> and provide the user with more readable information.
> 

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve