Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752754AbcCASuS (ORCPT ); Tue, 1 Mar 2016 13:50:18 -0500 Received: from mail-bn1on0089.outbound.protection.outlook.com ([157.56.110.89]:21728 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751062AbcCASuM (ORCPT ); Tue, 1 Mar 2016 13:50:12 -0500 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;vger.kernel.org; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: ettus.com; dkim=none (message not signed) header.d=none;ettus.com; dmarc=none action=none header.from=opensource.altera.com; Date: Tue, 1 Mar 2016 12:47:48 -0600 From: atull X-X-Sender: atull@linuxheads99 To: Moritz Fischer CC: , Subject: Re: [PATCH] fpga-manager: Replaced macro with static inline function In-Reply-To: <1456853973-31261-1-git-send-email-moritz.fischer@ettus.com> Message-ID: References: <1456853973-31261-1-git-send-email-moritz.fischer@ettus.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BLUPR01CA024.prod.exchangelabs.com (25.160.23.14) To CY1PR03MB1519.namprd03.prod.outlook.com (25.163.17.25) X-MS-Office365-Filtering-Correlation-Id: 9d02e272-2e8f-47bc-5a18-08d34202501e X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1519;2:SQsbUulNKtKwxjAaiG1pvyZ7up5hprkJ0P8trggObbUYw/w4LNiEQd0LlNN2kXj1dFoOI3RB7ZlAEpg7dSRadipcgJV2LqT+GBLSrtfD4lx3KOG5wXfyL27UKjN4MLo1Q8ULgAX8obVcoalmFBITeHyhQsBcIL28H3s6cwgJBS5uF29kUmqwR9nhbqfXsJ3Y;3:bNjt+esdLH6aLBgyGdVsupMvfELdcW87gq9rfQKClMjoVtAVF5hpC6FA18jQzX9Gqos851Fd5sOO0ZVQwBHHx1fNMww3v6BV5dxO2Hqwqq08jhvKtWC6fFBsW85uz9p0;25:ziYxzXN+qZoIG0bohn2F1ljgA2Kgk6aQYtMzr2iv2wU6ZAyPP+WPFroVC6o0PvG8YJMyCTYrTzbblYackS3Z0sQIxhuam5LaDVcmmogAM5jxNQS5wNscHmZHWQadoh4MyDj0ffie1d8Mzdk2Bjcn3bPJ8F02xa02lyRXuL59H0DMCLZa5xD6xXwmPdX8dECIaMjDwy6wVdWqv4O/GAUPxUhSNdV18ersoeNmjba/hOdIuxPnqqRrkBDK1wlGLsc7wXXq3OQmGKCTbFXOOoU0ZdNP30jwG60Cl9H5JBiXvCQvdjh3sqXYPuY8TDIyb4+mpsiDlOwf5C/znunRslLOKA==;20:2+UDpqHzUX/E8WGvIQ61iaXso8uzfByEw17szg5bomHwk9OUV0QuS7LV8Bi3Z5/56P7mvefWaUUlmYjVCQJpchwf7Nn+9gOafvAilt5+bkdOXZSDf5CegXKGn3Bd4kesGoKNKzz9LuAV5rl5yjO9WnMVrRx+5On1rk+dEEIeEbw= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1519; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY1PR03MB1519;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1519;BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13024025)(8121501046)(13018025)(5005006)(13023025)(13017025)(10201501046)(3002001);SRVR:BLUPR0301MB2017;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB2017; X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1519;4:TqERpfBjHt5InFH9wCfB515fmcTbjE/dwcY9zdK2IUoSQKHTiikEQsZEecwRgIFx60lpOfrjzFQc8UtJ16yPWIIPJrQMV5HGvAgsmDIUEWhBNxx3bCOkIGa1h3fP0/5/XzHyqOksPiJNfAOf3cZ65aj8MD9SAiUkjQWaKBzYIvG7JaVhOnnuI8NwDWTmEUCKfcLzY4S0VYUdW5tm3pe8MED1KWokYdLNhzHg0Jrohu5xcqFq9aC81LJjI8cQHcU+E7ZWROGRALc9+eiscNspw30sYgjvi6Fbyev/rcOvGxZB+UfiG9TXugVQC2hjnqDQRymExy3M2aMPg8MhrlbrWdm9v6MxZNOMlvApNsguvC/b8CwtISEJAGFlkqHj+1SY X-Forefront-PRVS: 086831DFB4 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(76176999)(19580405001)(77096005)(83506001)(53416004)(19580395003)(92566002)(5001960100004)(81156009)(42186005)(33716001)(3846002)(1096002)(86362001)(4001350100001)(586003)(122386002)(46406003)(4326007)(86152002)(23726003)(47776003)(40100003)(110136002)(54356999)(2906002)(2950100001)(66066001)(50986999)(50466002)(6116002)(5008740100001)(87976001)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1519;H:linuxheads99.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;CY1PR03MB1519;23:vKJvUtLwODaYiciI0e7cbAlgVgir6DNg7falgKcFw?= =?us-ascii?Q?2LCeSVJ/eUKe8yOUXDjyPDe4Bx3QMHAo6DV3yTl1at0CrlR+dexgLEa/2om8?= =?us-ascii?Q?+edCtzhiTUeru2F/VRu6WXQ53UjYWdgTYqpsoiGWUNxAFX/bSmw/+rpjSdAa?= =?us-ascii?Q?ZExPgF/DyVqW7CGDVvPyAcHOX1CSQtWbF4VHrNvflYYTg0k7a+kFUKnmPnML?= =?us-ascii?Q?NEiqc7erMlv5ypNuwpW+QegDKMelE3G9OvTMoDU+TpG2tbXHclpiM7Q0bqzT?= =?us-ascii?Q?swItf8NKQkIpjVP7xRqNHihaDCSyy/cpcUAg1oxliIstcaasQz+YGVQZpas9?= =?us-ascii?Q?W0OOP0p42occrN74eQpYga8/vUpAQ/UvJ9sYls3Pj2RKUsZjj6G+sk7bVWld?= =?us-ascii?Q?aCKqbL2Z8M855hCZOuY1ujOJUxK/zdZ41lEouYrjR5bSAbawzxLBEz5EpkSB?= =?us-ascii?Q?oPt6ZpmFwzWU211uRwsuS53/1b5J5o/kMcgIeAt+tjYxu52v1UGIU1PIfDk1?= =?us-ascii?Q?KJ8g6mzEJXk///RBiGE4lWgFrLFZshVdjn4VaH5D59GdUcQK2Z9BlswgtWzq?= =?us-ascii?Q?fnX3On7u0ArfYSGArtkqFZaZqHdvQ8hhqAe1p8Q1pYSGygQJpjZo9PrGiDdM?= =?us-ascii?Q?K9Y18CBScI6T/v/Yu7/dXx5xImk+deub+oyZFtmpAI9QUu06U7MJARuq1iH2?= =?us-ascii?Q?KyUeMEMbcNW999fdj/tdW8fi9fNvdZSFYr+2obrwd1F7srD+/faWu2xkIlbC?= =?us-ascii?Q?Jff+zfAG0HriD16B34CATTPr8uhtG2kkUh1W59Co+4JDE8sffHXw2ugOIJf6?= =?us-ascii?Q?vhDWWElUfkAYrn4kVGwJZ+7m5xtQw9HiyZUTld2+0WYuHZiFmO91rfJc6FTN?= =?us-ascii?Q?2opLprCe+/4R6Asz/yavLOFs6iuQmibFbI95sBpvOxgG1x6L9LfgsAhVeEoP?= =?us-ascii?Q?leTykXsEx+5QXuf0arfkqYr7ODJMWi7BQk6ogGlaZlLOqsWWF5f4GuZRWvl9?= =?us-ascii?Q?bg=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1519;5:YKD6I42X7NkPrYzE0fhyhBFBtp2ryqk8lW5ab93XyKllf2InISufLaYhEVkgUh9xeEnmA169KZqls4P8CHWWhipal4CYxnoMRrTvo5VFiRprRiaQF8PZUK0BFCnfVU+kkUjMSUBA7U0Vac+Wah5zJg==;24:qnCgR5Iy4wLYqpMUKgXz23iwfwR0uZp7c6gD9n5ODhFp52ZHA6/uAUFzJ1SChQ+XyTt0N0QR/a/OucbC6kFUwjJCA56Lt8oT6VeG61NUs1E=;20:nXK/hX84Xz8f1JAHAySBgG3UgXDc6ldKg8vuXw5cYKOpZO5ZbbXsEg5oOw5vJa/Xr3pNm0czRca437ion0xmTqWaagD0F6ugG1uenJDVtbb733CqsrhXiP5jI6czLPEYwQwE4lry1UeGLUtP8P6ifgxWX32bPM8dPYo64HTLJSQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1519 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD051.protection.gbl X-Forefront-Antispam-Report: CPI:66.35.236.236;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(199003)(24454002)(189002)(50466002)(46406003)(92566002)(110136002)(85426001)(53416004)(86362001)(47776003)(16796002)(4001350100001)(66066001)(122386002)(5001960100004)(81156009)(105606002)(33716001)(19580395003)(40100003)(21840400001)(19580405001)(4326007)(77096005)(87936001)(2950100001)(86152002)(5008740100001)(6806005)(106466001)(83506001)(956001)(1220700001)(3846002)(76176999)(2906002)(189998001)(54356999)(23726003)(50986999)(6116002)(1096002)(586003)(3720700001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0301MB2017;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD051;1:C8LaJSsxKnEblQljk1ePJP1sGHYNBYGUcaUHjg92kHFBGkY8ymkDUizekB5mu89r3n8BCbpZLaBh8iqHsfn0aJKZUT2Sg25D//GS0ZPcWywYqhQz/GxFFiBlGuY1w99PJarKjg+tggHVsyC2cqxwLjdPj/i4lmh/r7nRNdJwxlrgdWb5FAroocnPC7qffW16sYASOySesdOq2FGgcBd6ta31fzvTD9pRcJ4TxLPXTaeVUFCMxEyrZUXzLjnGItQ9x4OBZPMDJxHvFPghf1IW+KRwP9uJSjrvC/2HZTYDP3EjF3Y0o1eVo/VO3A0QG9aplD3eulztvR4gsLzLpZgBVnf8rxV/HRq4vbU7nV8cwky5PbQjCZYFc5EVESoh1VAO1H6S8G1TcPc4H34xVoL4VZj82Wy+8B9qiDmo76Hqotf1ufBKpqjC9npA+wJCNfZiuppAz45G6ajLV2xPdWov2A== X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB2017;2:FOLdXfrUvrcLFtkqZDnrr7m+zYOnTu3lFLadtItgxdNFw4OmLsiUUTbzK6sH0Kt3dC0elhCQDxpgWOuruI3l7ZDPqgPOOFIOLTkKjFEUJ2SWP8QnuJMaL4fScLkgVOoNumkQm0A6CBJing0wigPRKlkaMUwEAWiCDINxCn/GPRyndOgSMSCWn6Rt7E9Q9uxL;3:kTPwmc8+VKmEqWbl7sSJ/SE0R/tWWIixqtYio2vAZZp+lGC21QmfofWehS1ZqKrRXC3duP/gsxxU+AB0CL1y+op+xRTazL4ovmJqb8QpkBRUt7YrjavaTHbUyTwn2CabAOV7RV2VxgxVpzt6CEMTcdyzgJMLff6iVp2mFg8Lb/Qh9yWWV2QQ0Q2GrpLA1Tu/9Idj+KLLIvJkBczmpXneGw==;25:4p5xmGmre5bGcId6zvuteDZViDUc/AHatKWKiCxaXQtZJim+lr00UD06WPzj706xjl/dbSW6s8fxdaeWU7DUH6w6W0OfmCzc9HGy1RAwN0V+3kEngePKL/DGzBiYFo6WMRZYATXcf4m2twc/hpF11/BQRJoq7p1P8yTEWL/sFLlRuNYX8S74kG9LUC/p+UePvm5wCmRuPmZgnfeXK5qXpNoXTKIpDBQ6xp6pY2z2A1BdKDnYxodeZgtVINw4s8NU37ZC4/T6Ig29S2RbzBB7+P/0kEbZ8eOr2l1sEn6jsmtMP5fiuWBOqLIjIGvPHWg6INcMovYxWwbAF/oOwWp98Q==;20:jgvOCtIIGFR4UzNxfYq7Aw3XJOXZrjRIXN4XWOuFW+92YUY2XGOwKd1oQKj8L11xV+7L9pEvsqvNTH0KoosYnBzOaciicS+ga9ijauMn5efTq8vm+hDkjFB0mwBOXrSQh6OTEqthnLLsMgCM57/xTypTJ43zywukBSRodiHsqZg= X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BLUPR0301MB2017; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB2017;4:f9H/KTkX/rem5f3H1xupz6BuUeDNQhFTCUMgHx9kLc+u1seHel8dzLwd2a5cMOAL8z09vFfY/4U3LPwANMf2ZnM9ijXCKCwuHkfz763HtPSejoKLdFMQwynXqUPLF1VXOE13HZQcJecnPU6bCjS+LOMWdg/E3Z2QW5sjMhIibSV4I5yFvbs4zIAym4qFaN9rvX5ngyXY5l9iXZ4da+8JH9doIXC5FDAPYGScD8kNKwh2CVPeISAGi0RwYIT1lkUqdj/hqbE5XPoytCjcg9F3LkeJYxenTtnUkewl7AO6fk9MHYEdMHvNRj2g1RnL0VP63LtO+oKKoBMJWtYmg15evFA2vuuGg/Z0NjZUALv6XdNC7CFx3njn6TEJ+pxjhJ91V89yeBs56VaXXGv7heu26ac2xJOabNJGK06ZIwYp85PhiGto1iAsGPzMq3MuB5WMZ0utCiD0uRF0pVNUfhefVA== X-Forefront-PRVS: 086831DFB4 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR0301MB2017;23:wJNZvtinagzw//HRzKAoCj9V1Ce9cGqs8inJ7zI?= =?us-ascii?Q?BsJc0ktQaVV/uvbNmUAtUfUJpEwL6AxDjYCRuJzwfmnzOvrIASZ6MULPRJ7s?= =?us-ascii?Q?j3Vy9/TpRzLfWTp21TVDeGlmfaOemHw0BZi0Faj/fkf/tnIWoA6TdjmOBHKt?= =?us-ascii?Q?GhHcm0yZjXG1wG327WJNrFYg50Lnc276L2o49pLNE74Nis4vyz5bYX1SEG6O?= =?us-ascii?Q?KtjpGjf/ps8Gr7bwyBf2hWq6wB7bbaNApUm/J1sxjlJPQc5N/7TRB8dWfSGK?= =?us-ascii?Q?vusOo+sQ5L/k2xI7QOG+iFIvX017giPOcrDHQpRtNRho5Ouqu9dlNOd5U9ob?= =?us-ascii?Q?ZCqqpkTEpBWbKHSMOTZIwZJfmQIVNTi3LKA0pl4fhUvXGhRDmCRCt4ruzBJG?= =?us-ascii?Q?KzItxuP5a+pUxrc/h6++5PV7NERH3Twis/qWgZQO0aKlIr/OrYgmkKgoSaS4?= =?us-ascii?Q?5aEioT8Z0UEsSV5hG6NPpYkr44hbu2cuyyO4qZP6iHWGZ6wFYMo5Q2Wqx6Hf?= =?us-ascii?Q?XOol1rJWNHUnNk9oHaNGb+YAIbXcogKQ5L5tcUjzKHYIc17fySGVTQPwoA+v?= =?us-ascii?Q?8o1CTXLLxHClfMvT9x1FO27IO4af+LigWgNCpKvhPeA8J+FaYNRm1ssHbrCf?= =?us-ascii?Q?CDjJljfNUGwah1nVD4QsLgoLrvYUmkQfh+wSGS5MOQ4ghIqO21er0t45L4np?= =?us-ascii?Q?Bi/P3vTjRDRwZm84YrifbrLSx6eSQ/sRZOyI3I3peuIt21Zm5qw6xiiwGFYZ?= =?us-ascii?Q?j0mlpen2O75w9GxKiMbHOGlRjsj1aTYJc5goyttu6+pGfnFUE4ixe3FjuS2r?= =?us-ascii?Q?rTjdLUfi4R3C33YBX5oxvYij3dpX+q3ZeqM+k2fAIWkil8/SGVgKB7mxFJTe?= =?us-ascii?Q?kivVHjd/kwR4VV7bVSWKAmCR4l08HCkGc1WCIxNzqgz8lyFwIzJjyjeSaY0J?= =?us-ascii?Q?XDiV+INAzRp/EYt8KmGzU1+q0r6IPI6VIeUmi1zJij6OxsuFgktiFAwe2V2M?= =?us-ascii?Q?LefZ3tW5wJ7gOZnwyRS3Ly6jVBnXRzPqcOLkgvct/0D2fy2ORNstj9PNG1i1?= =?us-ascii?Q?xWTQmUSOWfbq8latgAXc4bv7KcZzNd2XS0Eg0Fe/mhHOTfcD3z9Rdiaj3JFk?= =?us-ascii?Q?/jt4iHW8BDFBvSS+TXMxIpJ8vwPeCB4Bsrtozx16Gy23lBcTA28u1wAAhJPC?= =?us-ascii?Q?6LARPQxE8z74bRJuhs7JgoWeoPLiSrRZhxZvzAFH3saPUzMjPdmM7swNxRN5?= =?us-ascii?Q?17G/4vvkyxMvEIvHu5DcPBQC+66lIFwdmVJQelVB+qJciOWbYHsI47lRoOKN?= =?us-ascii?Q?Rgw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB2017;5:RkVCoOFaum6/nMJuPlIzJb5JdiQJH/MGgvwgnVRSbmZsWCeatdQhy6hCdwGYjgRBss0u+ExSmcHWInM/IPOafz+upn6Wp2CvpzQvrpoJ3uC13CUSoavQkCe+F3DxxskTe6mpaIq34PSs/nPGCk2tMg==;24:eKHCKECDqPivv7hd750+HaoabB6k7fV7FyVHga2BZZ6JkVUho3ayMsgp55aml0RmWbM1JqzgBD7jHPXFpiV07ZaHRc+5lEiQErFrV8a6WSY=;20:MC+Qqf1meU38m2GsI98ScYPt+qfgYWSgBiHV+uJTUGLQq49Yd2I+8zMBQBU98vDD3qGhkdbXVrWSdR+u6Lg46G8wp1VH/FcGsFrhKxYV6wSjRUZq6ZI8yboB6iILjHgCES366RRJfW5VoR6hCNzcdo5/vHCgeO6CapLoELulR/M= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2016 18:50:08.7318 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB2017 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 902 Lines: 36 On Tue, 1 Mar 2016, Moritz Fischer wrote: > Signed-off-by: Moritz Fischer > --- > include/linux/fpga/fpga-mgr.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h > index 0940bf4..8064f1b 100644 > --- a/include/linux/fpga/fpga-mgr.h > +++ b/include/linux/fpga/fpga-mgr.h > @@ -107,7 +107,10 @@ struct fpga_manager { > void *priv; > }; > > -#define to_fpga_manager(d) container_of(d, struct fpga_manager, dev) > +static inline struct fpga_manager *to_fpga_manager(struct device *d) > +{ > + return container_of(d, struct fpga_manager, dev); > +} Hi Moritz, I really appreciate your work on this stuff. But I don't think we need to do this. Alan > > int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, > const char *buf, size_t count); > -- > 2.4.3 > >