Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753876AbcCATzr (ORCPT ); Tue, 1 Mar 2016 14:55:47 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:33238 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752728AbcCATzp (ORCPT ); Tue, 1 Mar 2016 14:55:45 -0500 Date: Tue, 1 Mar 2016 14:54:38 -0500 From: Johannes Weiner To: Vladimir Davydov Cc: Tejun Heo , Andrew Morton , Michal Hocko , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] cgroup: reset css on destruction Message-ID: <20160301195438.GB22717@cmpxchg.org> References: <69629961aefc48c021b895bb0c8297b56c11a577.1456830735.git.vdavydov@virtuozzo.com> <92b11b89791412df49e73597b87912e8f143a3f7.1456830735.git.vdavydov@virtuozzo.com> <20160301163018.GE3965@htj.duckdns.org> <20160301165630.GB2426@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160301165630.GB2426@esperanza> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 19 On Tue, Mar 01, 2016 at 07:56:30PM +0300, Vladimir Davydov wrote: > From: Vladimir Davydov > Subject: [PATCH] cgroup: reset css on destruction > > An associated css can be around for quite a while after a cgroup > directory has been removed. In general, it makes sense to reset it to > defaults so as not to worry about any remnants. For instance, memory > cgroup needs to reset memory.low, otherwise pages charged to a dead > cgroup might never get reclaimed. There's ->css_reset callback, which > would fit perfectly for the purpose. Currently, it's only called when a > subsystem is disabled in the unified hierarchy and there are other > subsystems dependant on it. Let's call it on css destruction as well. > > Suggested-by: Johannes Weiner > Signed-off-by: Vladimir Davydov It's already in a git tree, but FWIW Acked-by: Johannes Weiner