Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753440AbcCAVsR (ORCPT ); Tue, 1 Mar 2016 16:48:17 -0500 Received: from mail-vk0-f44.google.com ([209.85.213.44]:35631 "EHLO mail-vk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbcCAVsM (ORCPT ); Tue, 1 Mar 2016 16:48:12 -0500 MIME-Version: 1.0 In-Reply-To: <3183435.BG93qPHVgS@vostro.rjw.lan> References: <1456359748-22838-1-git-send-email-dbasehore@chromium.org> <1456359748-22838-2-git-send-email-dbasehore@chromium.org> <3183435.BG93qPHVgS@vostro.rjw.lan> Date: Tue, 1 Mar 2016 13:48:06 -0800 X-Google-Sender-Auth: 9BTzkCfs6DlukBw4-jgvrWYo7Tk Message-ID: Subject: Re: [PATCH v2 2/3] PM / sleep: try to runtime suspend for direct complete From: "dbasehore ." To: "Rafael J. Wysocki" Cc: Linux-pm mailing list , Len Brown , Pavel Machek , Greg Kroah-Hartman , linux-kernel , "Martin K . Petersen" , linux-scsi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1873 Lines: 47 On Sat, Feb 27, 2016 at 5:31 PM, Rafael J. Wysocki wrote: > On Wednesday, February 24, 2016 04:22:27 PM Derek Basehore wrote: >> This tries to runtime suspend devices that are still active for direct >> complete. This is for cases such as autosuspend delays which leaves >> devices able to runtime suspend but still active. It's beneficial in >> this case to runtime suspend the device to take advantage of direct >> complete when possible. >> >> Signed-off-by: Derek Basehore >> Reviewed-by: Eric Caruso >> --- >> drivers/base/power/main.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c >> index e0017d9..9693032 100644 >> --- a/drivers/base/power/main.c >> +++ b/drivers/base/power/main.c >> @@ -1380,7 +1380,12 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async) >> goto Complete; >> >> if (dev->power.direct_complete) { >> - if (pm_runtime_status_suspended(dev)) { >> + /* >> + * Check if we're runtime suspended. If not, try to runtime >> + * suspend for autosuspend cases. >> + */ >> + if (pm_runtime_status_suspended(dev) || >> + !pm_runtime_suspend(dev)) { >> pm_runtime_disable(dev); >> if (pm_runtime_status_suspended(dev)) >> goto Complete; >> > > This can be done somewhat simpler, because pm_runtime_suspend() will check > if the device has already been suspended: > > ret = pm_runtime_suspend(dev); > if (ret >= 0) { > > and you don't need the extra pm_runtime_status_suspended(dev) check. > > Thanks, > Rafael > I'll look into simplifying it for the next patch set.