Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756523AbcCBA3g (ORCPT ); Tue, 1 Mar 2016 19:29:36 -0500 Received: from mail-io0-f173.google.com ([209.85.223.173]:35388 "EHLO mail-io0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932363AbcCBA3d (ORCPT ); Tue, 1 Mar 2016 19:29:33 -0500 MIME-Version: 1.0 In-Reply-To: <20160229153011.GJ22747@8bytes.org> References: <1456758285-25060-1-git-send-email-joro@8bytes.org> <56D45FEA.9030307@redhat.com> <20160229153011.GJ22747@8bytes.org> From: Steve Rutherford Date: Tue, 1 Mar 2016 16:28:52 -0800 Message-ID: Subject: Re: [PATCH 0/3] KVM: Fix lost IRQ acks for RTC To: Joerg Roedel Cc: Paolo Bonzini , Gleb Natapov , KVM list , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 28 This issue seems generic to level triggered interrupts as well as RTC interrupts. It looks like KVM hacks around the issue with level triggered interrupts by clearing the remote IRR when an IRQ is reconfigured. Seems like an (admittedly lossy) way to handle this issue with the RTC-IRQ would be to follow the lead of level-triggered interrupts, and clear the pending EOIs when reconfiguring the RTC-IRQ. [Given that we are already talking about this, this could be viewed as a good time to go back and fix the issues with the remote IRR in the IOAPIC.] On Mon, Feb 29, 2016 at 7:30 AM, Joerg Roedel wrote: > On Mon, Feb 29, 2016 at 04:12:42PM +0100, Paolo Bonzini wrote: >> > This information is then used to match EOI signals from the >> > guest to the RTC. This explicit back-tracking fixes the >> > issue. >> >> Nice patches, really. Ok to wait until 4.6? > > Thanks. Putting them into v4.6 is fine for me. > > > Joerg > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html