Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932688AbcCBBR6 (ORCPT ); Tue, 1 Mar 2016 20:17:58 -0500 Received: from muru.com ([72.249.23.125]:47782 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755606AbcCAXzh (ORCPT ); Tue, 1 Mar 2016 18:55:37 -0500 Date: Tue, 1 Mar 2016 15:55:33 -0800 From: Tony Lindgren To: Stephen Boyd Cc: Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Tero Kristo Subject: Re: [PATCH] clk: ti: Fix some errors found by static checkers Message-ID: <20160301235532.GD4469@atomide.com> References: <1456858499-28035-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456858499-28035-1-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 12 * Stephen Boyd [160301 10:55]: > drivers/clk/ti/clk-814x.c:34:12: warning: symbol 'dm814x_adpll_early_init' was not declared. Should it be static? > drivers/clk/ti/clk-814x.c:58:12: warning: symbol 'dm814x_adpll_enable_init_clocks' was not declared. Should it be static? > drivers/clk/ti/adpll.c:465 ti_adpll_recalc_rate() warn: should '__readw(d->regs + 20) << 18' be a 64 bit type? > drivers/clk/ti/adpll.c:945 ti_adpll_probe() error: we previously assumed 'd->clocks' could be null (see line 921) > > The last one looks like a real bug because we don't return an > error on allocation failure. Yeah nice, that's a real bug: Tested-by: Tony Lindgren