Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756116AbcCBCEU (ORCPT ); Tue, 1 Mar 2016 21:04:20 -0500 Received: from mail333.us4.mandrillapp.com ([205.201.137.77]:42851 "EHLO mail333.us4.mandrillapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754451AbcCAXvZ (ORCPT ); Tue, 1 Mar 2016 18:51:25 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; q=dns; s=mandrill; d=linuxfoundation.org; b=PiaeD5FLrdn6W+uKtOlCOjytbKetXxBNJ8fC6h5alolpDTjspoqjZA4wg1LfnlI0sUFjwuxEVjLh QsCeC11L7eW7SyMZTS0XaLBBwXL+uDYlgJNychKfsjzTOM0CMNc0yTRJHwr5o0C4569ArH0K0qNq 0UY6jpixatB+mN+oYfA=; From: Greg Kroah-Hartman Subject: [PATCH 3.14 042/130] sched: Clean up idle task SMP logic X-Mailer: git-send-email 2.7.2 To: Cc: Greg Kroah-Hartman , , Peter Zijlstra , Daniel Lezcano , Vincent Guittot , , , Steven Rostedt , Byungchul Park Message-Id: <20160301234501.235545016@linuxfoundation.org> In-Reply-To: <20160301234459.768886030@linuxfoundation.org> References: <20160301234459.768886030@linuxfoundation.org> X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30481620.5a26a30723a7405a9735609ce1bf18c8 X-Mandrill-User: md_30481620 Date: Tue, 01 Mar 2016 23:51:05 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1754 Lines: 59 3.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Zijlstra commit 6c3b4d44ba2838f00614a5a2d777d4401e0bfd71 upstream. The idle post_schedule flag is just a vile waste of time, furthermore it appears unneeded, move the idle_enter_fair() call into pick_next_task_idle(). Signed-off-by: Peter Zijlstra Cc: Daniel Lezcano Cc: Vincent Guittot Cc: alex.shi@linaro.org Cc: mingo@kernel.org Cc: Steven Rostedt Link: http://lkml.kernel.org/n/tip-aljykihtxJt3mkokxi0qZurb@git.kernel.org Signed-off-by: Ingo Molnar Cc: Byungchul Park Signed-off-by: Greg Kroah-Hartman --- kernel/sched/idle_task.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) --- a/kernel/sched/idle_task.c +++ b/kernel/sched/idle_task.c @@ -19,11 +19,6 @@ static void pre_schedule_idle(struct rq idle_exit_fair(rq); rq_last_tick_reset(rq); } - -static void post_schedule_idle(struct rq *rq) -{ - idle_enter_fair(rq); -} #endif /* CONFIG_SMP */ /* * Idle tasks are unconditionally rescheduled: @@ -37,8 +32,7 @@ static struct task_struct *pick_next_tas { schedstat_inc(rq, sched_goidle); #ifdef CONFIG_SMP - /* Trigger the post schedule to do an idle_enter for CFS */ - rq->post_schedule = 1; + idle_enter_fair(rq); #endif return rq->idle; } @@ -102,7 +96,6 @@ const struct sched_class idle_sched_clas #ifdef CONFIG_SMP .select_task_rq = select_task_rq_idle, .pre_schedule = pre_schedule_idle, - .post_schedule = post_schedule_idle, #endif .set_curr_task = set_curr_task_idle,