Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751183AbcCBFO7 (ORCPT ); Wed, 2 Mar 2016 00:14:59 -0500 Received: from cooldavid.org ([114.33.45.68]:56031 "EHLO cooldavid.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbcCBFO6 (ORCPT ); Wed, 2 Mar 2016 00:14:58 -0500 From: "Guo-Fu Tseng" To: David Miller , diego.viola@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, richard.weinberger@gmail.com, pavel@ucw.cz, rjw@rjwysocki.net, valdis.kletnieks@vt.edu Subject: Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 Date: Wed, 2 Mar 2016 13:14:55 +0800 Message-Id: <20160302051405.M6687@cooldavid.org> In-Reply-To: <20160224.235856.242530723940439026.davem@davemloft.net> References: <1456239844-4109-1-git-send-email-diego.viola@gmail.com> <20160224.235856.242530723940439026.davem@davemloft.net> X-Mailer: OpenWebMail 2.53 X-OriginatingIP: 125.227.238.55 (cooldavid) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 731 Lines: 22 On Wed, 24 Feb 2016 23:58:56 -0500 (EST), David Miller wrote > From: Diego Viola > Date: Tue, 23 Feb 2016 12:04:04 -0300 > > > The JMC260 network card fails to suspend/resume because the call to > > jme_start_irq() was too early, moving the call to jme_start_irq() after > > the call to jme_reset_link() makes it work. > > > > Prior this change suspend/resume would fail unless /sys/power/pm_async=0 > > was explicitly specified. > > > > Relevant bug report: https://bugzilla.kernel.org/show_bug.cgi?id=112351 > > > > Signed-off-by: Diego Viola > > Applied and queued up for -stable, thanks. Just reviewed it, it should have no side effect. Thanks David, Diego. Guo-Fu Tseng