Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752839AbcCBGwg (ORCPT ); Wed, 2 Mar 2016 01:52:36 -0500 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:61963 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbcCBGwf (ORCPT ); Wed, 2 Mar 2016 01:52:35 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DEBgBhjNZWWsd6Ag5UCIJpUblghAeGEwKBPk0BAQEBAQEHAUNBhEIBAQMBOB4VDQEQCAMhFg8JAwIBAgEnChQGAQwIAogTB74iAQEBAQEBBAEBAQEchhKEOoQRhF4BBJcPgUKbF45MgmUZgVspiG8BAQE Subject: Re: [PATCH] eata: Convert eata driver as normal PCI and platform device drivers To: Jiang Liu , Christoph Hellwig References: <1456801344-3318-1-git-send-email-jiang.liu@linux.intel.com> <20160301065247.GA6670@infradead.org> <56D5D0F4.4060301@internode.on.net> <56D60B5A.3080209@internode.on.net> <56D65BF6.1050905@linux.intel.com> Cc: Dario Ballabio , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , "Ballabio, Dario" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Arthur Marsh Message-ID: <56D68DAA.5000206@internode.on.net> Date: Wed, 2 Mar 2016 17:22:26 +1030 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <56D65BF6.1050905@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1998 Lines: 52 Jiang Liu wrote on 02/03/16 13:50: >> I spoke too soon, without removing and re-inserting the eata module >> before any filesystems on disks attached to the DPT controller were >> mounted, I'd get the following messages, similar to ones previously >> reported: >> >> sd 0:0:6:0: tag#0 abort, mbox 1. >> EATA0: abort, mbox 1 is in use. >> sd 0:0:6:0: tag#0 reset, enter. >> EATA0: reset, mbox 1 in reset. >> EATA0: reset, board reset done, enabling interrupts. >> EATA0: reset, interrupts disabled, loops 100415. >> EATA0, reset, mbox 1 locked, DID_RESET, done. >> EATA0: reset, exit, done. >> >> >> and so on, finally hanging after printing "kexec_core: Starting new >> kernel" (I have a photo of the messages if they're needed). >> >> So I'm still using the new patch but have to continue to remove and >> reinsert eata at start-up before any attempts to mount disks attatched >> to the DPT SCSI controller. > Hi Authur, > Thanks for testing. So current situation is that we have > a working driver for normal case, but still have issues during kexec. > Per my understanding, we need to implement a PCI device driver shutdown > callback to reset the RAID controller. I have once tried to implement > the shutdown callback, but it doesn't work. And I have no deep > understanding of the RAID controller and have no hardware for > experiment too, so have no idea about next step. > Maybe one acceptable way is to merge this patch first, so > we get a basic working driver, and then ask help from expert to > solve the kexec issue. > Thanks! > Gerry My controller is a DPT2044W, it does not provide any hardware RAID capabilities. I'm not sure where responsibility lies in driver development but I'm still using the DPT2044W controller which worked on the 4.2.0 kernels and earlier and this problem has been around for nearly 5 months now. I can do builds and tests of any patches that people can provide, but am not a C programmer, much less a Linux driver developer. Regards, Arthur.