Date: Wed, 2 Mar 2016 09:37:21 +0100 (CET)
From: Jiri Kosina <jikos@kernel.org>
To: Sedat Dilek <sedat.dilek@gmail.com>
cc: Alan Stern <stern@rowland.harvard.edu>,
        Steven Rostedt <rostedt@goodmis.org>, Tejun Heo <tj@kernel.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Andy Lutomirski <luto@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        linux-usb@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning
In-Reply-To: <CA+icZUV9qDVLTAv_oj=Pj4Ry+f_kKUwJwejmGB+VBn4kzSLdTQ@mail.gmail.com>
Message-ID: <alpine.LNX.2.00.1603020936520.3656@cbobk.fhfr.pm>
References: <CA+icZUUCNAUDVqg1D-brJtZ2_QRxW_2s+jv0T5MPpCE9Y-auvg@mail.gmail.com> <Pine.LNX.4.44L0.1603011051150.1775-100000@iolanthe.rowland.org> <CA+icZUVDUSAp6NuNQOh5jf1Qc-mgONoyJ3RHkw+rWHw5OqUe6Q@mail.gmail.com>
 <CA+icZUV9qDVLTAv_oj=Pj4Ry+f_kKUwJwejmGB+VBn4kzSLdTQ@mail.gmail.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 613
Lines: 24

On Wed, 2 Mar 2016, Sedat Dilek wrote:
> 
> static bool start_flush_work(struct work_struct *work, struct wq_barrier *barr)
> {
>         struct worker *worker = NULL;
>         struct worker_pool *pool;
>         struct pool_workqueue *pwq;
> 
>         might_sleep();
> 
>         local_irq_disable();
>         pool = get_work_pool(work);
>         if (!pool) {
>                 local_irq_enable();
>                 return false;
>         }
> 
>         spin_lock(&pool->lock); <--- XXX: spin_lock_irq() ???

No, this is fine. IRQs are unconditionally disabled a few lines above.

-- 
Jiri Kosina
SUSE Labs