Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753676AbcCBJAk (ORCPT ); Wed, 2 Mar 2016 04:00:40 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:49569 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752881AbcCBJAi (ORCPT ); Wed, 2 Mar 2016 04:00:38 -0500 X-IBM-Helo: d23dlp01.au.ibm.com X-IBM-MailFrom: khandual@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Message-ID: <56D6AB70.3040503@linux.vnet.ibm.com> Date: Wed, 02 Mar 2016 14:29:28 +0530 From: Anshuman Khandual User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Cyril Bur CC: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V10 17/28] selftests, powerpc: Add ptrace tests for EBB References: <1455613198-5113-1-git-send-email-khandual@linux.vnet.ibm.com> <1455613198-5113-18-git-send-email-khandual@linux.vnet.ibm.com> <20160302113247.48a0e8d0@camb691> In-Reply-To: <20160302113247.48a0e8d0@camb691> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16030209-0029-0000-0000-00004425F3AD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3106 Lines: 84 On 03/02/2016 06:02 AM, Cyril Bur wrote: > On Tue, 16 Feb 2016 14:29:47 +0530 > Anshuman Khandual wrote: > >> This patch adds ptrace interface test for EBB specific >> registers. This also adds some generic ptrace interface >> based helper functions to be used by other patches later >> on in the series. >> >> Signed-off-by: Anshuman Khandual >> --- >> tools/testing/selftests/powerpc/Makefile | 3 +- >> tools/testing/selftests/powerpc/ptrace/Makefile | 7 + >> .../testing/selftests/powerpc/ptrace/ptrace-ebb.c | 150 ++++++++++++++ >> .../testing/selftests/powerpc/ptrace/ptrace-ebb.h | 103 ++++++++++ >> tools/testing/selftests/powerpc/ptrace/ptrace.h | 225 +++++++++++++++++++++ >> 5 files changed, 487 insertions(+), 1 deletion(-) >> create mode 100644 tools/testing/selftests/powerpc/ptrace/Makefile >> create mode 100644 tools/testing/selftests/powerpc/ptrace/ptrace-ebb.c >> create mode 100644 tools/testing/selftests/powerpc/ptrace/ptrace-ebb.h >> create mode 100644 tools/testing/selftests/powerpc/ptrace/ptrace.h >> >> diff --git a/tools/testing/selftests/powerpc/Makefile b/tools/testing/selftests/powerpc/Makefile >> index 0c2706b..5b3c62c 100644 >> --- a/tools/testing/selftests/powerpc/Makefile >> +++ b/tools/testing/selftests/powerpc/Makefile >> @@ -22,7 +22,8 @@ SUB_DIRS = benchmarks \ >> switch_endian \ >> syscalls \ >> tm \ >> - vphn >> + vphn \ >> + ptrace >> >> endif >> >> diff --git a/tools/testing/selftests/powerpc/ptrace/Makefile b/tools/testing/selftests/powerpc/ptrace/Makefile >> new file mode 100644 >> index 0000000..8666ac0 >> --- /dev/null >> +++ b/tools/testing/selftests/powerpc/ptrace/Makefile >> @@ -0,0 +1,7 @@ >> +TEST_PROGS := ptrace-ebb >> +all: $(TEST_PROGS) >> + >> +$(TEST_PROGS): ../harness.c ptrace.S ../utils.c >> +ptrace-ebb: ../pmu/event.c ../pmu/lib.c ../pmu/ebb/ebb_handler.S ../pmu/ebb/busy_loop.S >> +clean: >> + rm -f $(TEST_PROGS) *.o > > If you: > include ../../lib.mk > > Then this Makefile just works with run_tests and install targets from the > base Makefile Sure, will do that. > >> diff --git a/tools/testing/selftests/powerpc/ptrace/ptrace-ebb.c b/tools/testing/selftests/powerpc/ptrace/ptrace-ebb.c >> new file mode 100644 >> index 0000000..e1ca608 >> --- /dev/null >> +++ b/tools/testing/selftests/powerpc/ptrace/ptrace-ebb.c >> @@ -0,0 +1,150 @@ >> +/* >> + * Ptrace interface test for EBB >> + * >> + * Copyright (C) 2015 Anshuman Khandual, IBM Corporation. >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License >> + * as published by the Free Software Foundation; either version >> + * 2 of the License, or (at your option) any later version. >> + */ >> +#include "../pmu/ebb/ebb.h" >> +#include "ptrace.h" >> +#include "ptrace-ebb.h" >> + > > Check out tools/testing/selftests/powerpc/utils.h which provides a nice (and > super hacky) FAIL_IF() macro. Sure, will check it out and see where all it can be used.