Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753888AbcCBKJm (ORCPT ); Wed, 2 Mar 2016 05:09:42 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:18885 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753736AbcCBKJj (ORCPT ); Wed, 2 Mar 2016 05:09:39 -0500 Date: Wed, 2 Mar 2016 13:09:12 +0300 From: Dan Carpenter To: Chris Boot , "Nicholas A. Bellinger" Cc: target-devel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] sbp-target: checking for NULL instead of IS_ERR Message-ID: <20160302100912.GD5533@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 19 We changed this from kzalloc to sbp_mgt_get_req() so we need to change from checking for NULL to check for error pointers. Fixes: c064b2a78989 ('sbp-target: Conversion to percpu_ida tag pre-allocation') Signed-off-by: Dan Carpenter diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c index 251d532..a04b0605f 100644 --- a/drivers/target/sbp/sbp_target.c +++ b/drivers/target/sbp/sbp_target.c @@ -951,7 +951,7 @@ static void tgt_agent_fetch_work(struct work_struct *work) while (next_orb && tgt_agent_check_active(agent)) { req = sbp_mgt_get_req(sess, sess->card, next_orb); - if (!req) { + if (IS_ERR(req)) { spin_lock_bh(&agent->lock); agent->state = AGENT_STATE_DEAD; spin_unlock_bh(&agent->lock);