Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754743AbcCBK3Z (ORCPT ); Wed, 2 Mar 2016 05:29:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:40557 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754087AbcCBK3X (ORCPT ); Wed, 2 Mar 2016 05:29:23 -0500 Date: Wed, 2 Mar 2016 11:29:41 +0100 From: Jan Kara To: Tejun Heo Cc: Jens Axboe , Tahsin Erdogan , Jan Kara , Cgroups , "Theodore Ts'o" , Nauman Rafique , lkml , Jan Kara , Al Viro Subject: Re: [PATCH v2 block/for-linus] writeback: flush inode cgroup wb switches instead of pinning super_block Message-ID: <20160302102941.GC19633@quack.suse.cz> References: <20160216182457.GO3741@mtj.duckdns.org> <20160217205721.GE14140@quack.suse.cz> <20160217210744.GA6479@mtj.duckdns.org> <20160217223009.GN14140@quack.suse.cz> <20160217230231.GC6479@mtj.duckdns.org> <20160229204724.GV3965@htj.duckdns.org> <20160229232853.GD3965@htj.duckdns.org> <56D5D592.2020800@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 21 On Tue 01-03-16 12:50:19, Tejun Heo wrote: > Hello, Jens. > > On Tue, Mar 1, 2016 at 12:46 PM, Jens Axboe wrote: > > I queued this up for 4.5, but I'm feeling a bit uneasy about it. But it's > > either that, or revert 5ff8eaac1636 and fix it for real in 4.6. Jan/Tejun, > > what do you think? > > Given that this only matters for cgroup writeback cases, this should > still be fairly low impact, so I don't think it'd matter too much > whether we fix this in this cycle or for 4.6. However, that also means > that we're not risking much by doing it in this cycle, so I'd vote for > doing it now. Yeah, without CGROUP_WRITEBACK enabled this patch is NOP so I don't care much when this gets merged. Honza -- Jan Kara SUSE Labs, CR