Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754598AbcCBKuk (ORCPT ); Wed, 2 Mar 2016 05:50:40 -0500 Received: from mail.skyhub.de ([78.46.96.112]:57850 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbcCBKui (ORCPT ); Wed, 2 Mar 2016 05:50:38 -0500 Date: Wed, 2 Mar 2016 11:50:32 +0100 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: tony.luck@intel.com, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, dougthompson@xmission.com, mchehab@osg.samsung.com, x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, gong.chen@linux.intel.com, len.brown@intel.com, peterz@infradead.org, ak@linux.intel.com, alexander.shishkin@linux.intel.com Subject: Re: [PATCH V2 2/5] EDAC, MCE, AMD: Enable error decoding of Scalable MCA errors Message-ID: <20160302105032.GC16954@pd.tnic> References: <1456785179-14378-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1456785179-14378-3-git-send-email-Aravind.Gopalakrishnan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1456785179-14378-3-git-send-email-Aravind.Gopalakrishnan@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 29 On Mon, Feb 29, 2016 at 04:32:56PM -0600, Aravind Gopalakrishnan wrote: > For Scalable MCA enabled processors, errors are listed > per IP block. And since it is not required for an IP to > map to a particular bank, we need to use HWID and McaType > values from the MCx_IPID register to figure out which IP > a given bank represents. > > We also have a new bit (TCC) in the MCx_STATUS register > to indicate Task context is corrupt. > > Add logic here to decode errors from all known IP > blocks for Fam17h Model 00-0fh and to print TCC errors. > > Signed-off-by: Aravind Gopalakrishnan > --- > arch/x86/include/asm/mce.h | 53 ++++++ > arch/x86/kernel/cpu/mcheck/mce_amd.c | 11 ++ > drivers/edac/mce_amd.c | 342 ++++++++++++++++++++++++++++++++++- > 3 files changed, 405 insertions(+), 1 deletion(-) Ok, applied with a bunch of changes ontop. I'm sending them as a reply to this message. The second patch is relying on the assumption that a hwid of 0 is invalid. Is that so? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.