Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755399AbcCBND4 (ORCPT ); Wed, 2 Mar 2016 08:03:56 -0500 Received: from mail.kernel.org ([198.145.29.136]:47129 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755316AbcCBNDz (ORCPT ); Wed, 2 Mar 2016 08:03:55 -0500 Date: Wed, 2 Mar 2016 10:03:50 -0300 From: Arnaldo Carvalho de Melo To: Peter Zijlstra Cc: Colin King , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tests: initialize sa.sa_flags Message-ID: <20160302130350.GO3604@kernel.org> References: <1456923322-29697-1-git-send-email-colin.king@canonical.com> <20160302125901.GF6356@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160302125901.GF6356@twins.programming.kicks-ass.net> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 35 Em Wed, Mar 02, 2016 at 01:59:01PM +0100, Peter Zijlstra escreveu: > On Wed, Mar 02, 2016 at 12:55:22PM +0000, Colin King wrote: > > From: Colin Ian King > > > > The sa_flags field is not being initialized, so a garbage value is > > being passed to sigaction. Initialize it to zero. > > > > Signed-off-by: Colin Ian King > > --- > > tools/perf/arch/x86/tests/rdpmc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/perf/arch/x86/tests/rdpmc.c b/tools/perf/arch/x86/tests/rdpmc.c > > index 7bb0d13..7945462 100644 > > --- a/tools/perf/arch/x86/tests/rdpmc.c > > +++ b/tools/perf/arch/x86/tests/rdpmc.c > > @@ -103,6 +103,7 @@ static int __test__rdpmc(void) > > > > sigfillset(&sa.sa_mask); > > sa.sa_sigaction = segfault_handler; > > + sa.sa_flags = 0; > > Would not something like: > > sa = (struct sigaction){ > .sa_sigaction = segfault_handler, > }; > sigfillset(&sa.sa_mask); > > Be better? I thought about that, but isn't that set in stone? This would be a 4 liner, while his is a one' :-) - Arnaldo