Subject: Re: [PATCH 3/3] EDAC, mce_amd: Correct error paths
To: Borislav Petkov <bp@alien8.de>
References: <1456785179-14378-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
 <1456785179-14378-3-git-send-email-Aravind.Gopalakrishnan@amd.com>
 <20160302105032.GC16954@pd.tnic> <20160302105445.GF16954@pd.tnic>
CC: <tony.luck@intel.com>, <hpa@zytor.com>, <mingo@redhat.com>,
        <tglx@linutronix.de>, <dougthompson@xmission.com>,
        <mchehab@osg.samsung.com>, <x86@kernel.org>,
        <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <ashok.raj@intel.com>, <gong.chen@linux.intel.com>,
        <len.brown@intel.com>, <peterz@infradead.org>, <ak@linux.intel.com>,
        <alexander.shishkin@linux.intel.com>
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Message-ID: <56D70D2B.2000302@amd.com>
Date: Wed, 2 Mar 2016 09:56:27 -0600
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160302105445.GF16954@pd.tnic>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2016 15:56:31.9118
 (UTC)
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0713
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 985
Lines: 38

On 3/2/2016 4:54 AM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> Date: Wed, 2 Mar 2016 11:46:58 +0100
> Subject: [PATCH 3/3] EDAC, mce_amd: Correct error paths
>
> We need to unwind properly when we fail to find the proper decoding
> functions. Streamline error messages to resemble the rest of this file,
> while at it and do some minor stylistic changes.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>

Looks good. Thanks.

Reviewed-by: Aravind Gopalakrishnan<aravind.gopalakrishnan@amd.com>

> -
>   
>   	default:
>   		printk(KERN_WARNING "Huh? What family is it: 0x%x?!\n", c->x86);
> -		kfree(fam_ops);
> -		fam_ops = NULL;
> +		goto err_out;
>   	}
>   
>   	pr_info("MCE: In-kernel MCE decoding enabled.\n");
> @@ -1225,6 +1224,11 @@ static int __init mce_amd_init(void)
>   	mce_register_decode_chain(&amd_mce_dec_nb);
>   
>   	return 0;
> +
> +err_out:
> +	kfree(fam_ops);
> +	fam_ops = NULL;
> +	return -EINVAL;

Thanks! Sorry I missed this.

-Aravind.