Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755653AbcCBQWH (ORCPT ); Wed, 2 Mar 2016 11:22:07 -0500 Received: from mail-bl2on0147.outbound.protection.outlook.com ([65.55.169.147]:1342 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752358AbcCBQWF convert rfc822-to-8bit (ORCPT ); Wed, 2 Mar 2016 11:22:05 -0500 From: Hartley Sweeten To: Ian Abbott , "devel@driverdev.osuosl.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro Thread-Topic: [PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro Thread-Index: AQHRdI+zCgo+GVrj9kC14Y/1Lmfjx59GVa+A Date: Wed, 2 Mar 2016 16:21:57 +0000 Message-ID: References: <1456928858-6014-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1456928858-6014-1-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mev.co.uk; dkim=none (message not signed) header.d=none;mev.co.uk; dmarc=none action=none header.from=visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: 26b5e384-2ff9-497e-1884-08d342b6c6f1 x-microsoft-exchange-diagnostics: 1;BN3PR0101MB1057;5:HgWra/8tIu2wm8SBLiiFbdrVt5uxY948PlVrSQnAJ0GTJSWacmJNmwAMXN4ZiJJXODOFje5DYxawwPvswfhBzhYvbJYr5UFfpAJzFOhsgwMN9rwdBuFXCCCJoCXMFJsUDpWA5+4XKIZTgaO1g6EJrQ==;24:q9ldBJ/RGb360WiYv3b4sams+yTbwnynPkjOGDFRSc4IyzQDF7WQFOKPKxwaFPbHyZ5wFwdOC/loLQpAsNt84RTsfBTXpvzU8AKLMxaAeI8= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1057; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN3PR0101MB1057;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1057; x-forefront-prvs: 086943A159 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(52604005)(1096002)(5003600100002)(5002640100001)(3846002)(19580395003)(3660700001)(189998001)(2900100001)(4326007)(2950100001)(81156010)(2501003)(2906002)(5004730100002)(19580405001)(1220700001)(122556002)(106116001)(6116002)(5008740100001)(586003)(11100500001)(77096005)(3280700002)(76176999)(86362001)(40100003)(87936001)(102836003)(66066001)(54356999)(5001960100004)(33656002)(92566002)(10400500002)(80792005)(74316001)(5001770100001)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0101MB1057;H:BN3PR0101MB1057.prod.exchangelabs.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2016 16:21:57.5104 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0101MB1057 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 821 Lines: 18 On Wednesday, March 02, 2016 7:28 AM, Ian Abbott wrote: > Patch 1 effectively reverts commit 72315cdaba9d on linux-next "Staging: > comedi: Prefer using the BIT macro"), but I replaced the use of the BIT > macro with hexadecimal constants instead of the original left bit-shift > expressions. We shouldn't use the BIT macro in "comedi.h" as it is > intended to be included in the UAPI headers. > > Patch 2 just fixes the kernel-doc comment for struct comedi_krange. > > 1) staging: comedi: comedi.h: Do not use BIT macro > 2) staging: comedi: comedi.h: Fix comment for struct comedi_krange > > drivers/staging/comedi/comedi.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Thanks for fixing this. I noticed the same issue yesterday. Reviewed-by: H Hartley Sweeten