Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756107AbcCBQWn (ORCPT ); Wed, 2 Mar 2016 11:22:43 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:45431 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132AbcCBQWk (ORCPT ); Wed, 2 Mar 2016 11:22:40 -0500 Subject: Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS To: Tony Lindgren , Paul Walmsley References: <1456439796-28546-1-git-send-email-fcooper@ti.com> <1456439796-28546-3-git-send-email-fcooper@ti.com> <20160301181109.GB13417@atomide.com> <20160301205043.GA4469@atomide.com> CC: , , , , , , , From: "Franklin S Cooper Jr." Message-ID: <56D71331.5020702@ti.com> Date: Wed, 2 Mar 2016 10:22:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160301205043.GA4469@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 32 Hi Paul On 03/01/2016 02:50 PM, Tony Lindgren wrote: > * Paul Walmsley [160301 10:59]: >> On Tue, 1 Mar 2016, Tony Lindgren wrote: >> >>> * Franklin S Cooper Jr [160225 14:37]: >>>> From: Vignesh R >>>> >>>> Add hwmod entries for the PWMSS on DRA7. >>>> >>>> Set l4_root_clk_div as the main_clk of PWMSS. It is fixed-factored clock >>>> equal to L4PER2_L3_GICLK/2(l3_iclk_div/2). >>>> As per AM57x TRM SPRUHZ6[1], October 2014, Section 29.1.3 Table 29-4, >>>> clock source to PWMSS is L4PER2_L3_GICLK. But it is actually >>>> L4PER2_L3_GICLK/2. The TRM does not show the division by 2. >>>> >>>> [1] www.ti.com/lit/ug/spruhz6/spruhz6.pdf >>> Looks OK to me, assuming Paul will pick this one or ack it. >> Well I've already sent comments on it, it doesn't look quite ready for me >> yet. I would hold off on the whole series because the hwmod comments also >> impact the DT files. > OK will drop the dt related patches then. Sorry you previously asked this question about why hwmod is used for eCap, ePWM and eQEP before and it wasn't addressed. I'll take a look at this and I will get back to you. > > Regards, > > Tony