Subject: Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding
To: Borislav Petkov <bp@alien8.de>
References: <1456785179-14378-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
 <1456785179-14378-3-git-send-email-Aravind.Gopalakrishnan@amd.com>
 <20160302105032.GC16954@pd.tnic> <20160302105353.GE16954@pd.tnic>
 <56D70C37.1090902@amd.com> <20160302162138.GL16954@pd.tnic>
CC: <tony.luck@intel.com>, <hpa@zytor.com>, <mingo@redhat.com>,
        <tglx@linutronix.de>, <dougthompson@xmission.com>,
        <mchehab@osg.samsung.com>, <x86@kernel.org>,
        <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <ashok.raj@intel.com>, <gong.chen@linux.intel.com>,
        <len.brown@intel.com>, <peterz@infradead.org>, <ak@linux.intel.com>,
        <alexander.shishkin@linux.intel.com>
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Message-ID: <56D7148D.2080806@amd.com>
Date: Wed, 2 Mar 2016 10:27:57 -0600
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160302162138.GL16954@pd.tnic>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2016 16:28:00.5568
 (UTC)
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0709
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1907
Lines: 50

On 3/2/2016 10:21 AM, Borislav Petkov wrote:
> On Wed, Mar 02, 2016 at 09:52:23AM -0600, Aravind Gopalakrishnan wrote:
>> So, I think we should continue this approach and have something like this-
>> static const char * const amd_core_mcablock_names[] = {
>>          [SMCA_LS]         = "load_store",
>>          [SMCA_IF]         = "insn_fetch",
>>          [SMCA_L2_CACHE]   = "l2_cache",
>>          [SMCA_DE]         = "decode_unit",
>>          [RES]                   = "",
>>          [SMCA_EX]         = "execution_unit",
>>          [SMCA_FP]         = "floating_point",
>>          [SMCA_L3_CACHE]   = "l3_cache",
>> };
>>
>> static const char * const amd_df_mcablock_names[] = {
>>          [SMCA_CS]  = "coherent_slave",
>>          [SMCA_PIE] = "pie",
>> };
>>
>> (Split arrays again because I feel it'd be better to have arrays ordered
>> according to mca_type values)
> Ok, care to take the patch and redo it as you suggest?

Sure. I was going to introduce these strings as part of patch to update 
sysfs code to
understand the new banks anyway. So it's already in the works:)

> I really don't want to be assigning strings each time during decoding.

Ok, Will update the EDAC to use the existing string array.

> Also, make sure the strings are as human readable as possible and so
> that users can at least have an idea what we're saying. "load_store"
> is better than "LS", "insn_fetch" is better than "IF", etc. Some
> abbreviations should remain, though. "platform_security_processor" is
> yucky and I guess there we can stick to "PSP". Ditto for "SMU"...

Understood. Will do as you suggest.

> Making the unabbreviated lowercase for sysfs usage is fine too, of
> course.
>
>

So, have you pushed the set of patches you applied somewhere? (bp.git?)
I can work on top of those and it will be easier to rebase on top of tip.git
once the patches find their way there..

Thanks,
-Aravind.