Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755133AbcCBQfn (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Mar 2016 11:35:43 -0500
Received: from smtprelay0007.hostedemail.com ([216.40.44.7]:57188 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753923AbcCBQfk (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Mar 2016 11:35:40 -0500
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2197:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3653:3865:3868:3871:3872:3874:4605:5007:6119:6261:6742:7875:7903:7988:9040:9121:10004:10400:10848:10967:11026:11232:11658:11914:12517:12519:12555:12740:13069:13311:13357:13439:13548:14581:14659:21080:21221:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: idea14_4e1773dc6e14b
X-Filterd-Recvd-Size: 3458
Date: Wed, 2 Mar 2016 11:35:35 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Sedat Dilek <sedat.dilek@gmail.com>, Jiri Kosina <jikos@kernel.org>,
        Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Andy Lutomirski <luto@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        linux-usb@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>, Felipe Balbi <balbi@ti.com>,
        Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning
Message-ID: <20160302113535.6abe9a2c@gandalf.local.home>
In-Reply-To: <20160302162412.GI6357@twins.programming.kicks-ass.net>
References: <CA+icZUV7pxXoApuLdc7Z=kMHiKG=diHNqsnR5-MHpER=XkjQVQ@mail.gmail.com>
	<CA+icZUUyaHqHP2v52juhGhoTNS9xX7LT2YxkOppLz6f9Z+FBEA@mail.gmail.com>
	<CA+icZUWagGMVNs5gBPRBhYO0LsY2A1hK3KSLabp9ZpDVOTmtig@mail.gmail.com>
	<20151012205755.7ad86f4c@grimm.local.home>
	<CA+icZUUCNAUDVqg1D-brJtZ2_QRxW_2s+jv0T5MPpCE9Y-auvg@mail.gmail.com>
	<20160301100740.759440b7@gandalf.local.home>
	<20160301151700.GU6356@twins.programming.kicks-ass.net>
	<CA+icZUVgo0FSZ17ZgA4kyBSzFuNx7aMi6FxH6MdbJYxzi+1V4A@mail.gmail.com>
	<20160302151713.GG6357@twins.programming.kicks-ass.net>
	<CA+icZUWvduot+7Tnm9w8ETj-dzEs=7Mp1ZchLcK5TDYBNmPFXQ@mail.gmail.com>
	<20160302162412.GI6357@twins.programming.kicks-ass.net>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1503
Lines: 43

On Wed, 2 Mar 2016 17:24:12 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, Mar 02, 2016 at 04:53:36PM +0100, Sedat Dilek wrote:
> > ffffffff8110f570 <del_timer_sync>:
> > ffffffff8110f570:	55                   	push   %rbp
> > ffffffff8110f571:	48 89 e5             	mov    %rsp,%rbp
> > ffffffff8110f574:	41 57                	push   %r15
> > ffffffff8110f576:	41 56                	push   %r14
> > ffffffff8110f578:	53                   	push   %rbx
> > ffffffff8110f579:	48 83 ec 28          	sub    $0x28,%rsp  
> 
> stack offset is 0x28 bytes [*]

Actually, isn't it really 0x40 bytes? The stack pushed 3 words (8 bytes
each) before doing the subtract. 0x28 == 40 bytes, 3 * 8 = 24,
40 + 24 = 64 == 0x40.

> 
> > ffffffff8110f57d:	48 89 fb             	mov    %rdi,%rbx
> > ffffffff8110f580:	e8 6b 6e 80 00       	callq  ffffffff819163f0 <mcount>
> > ffffffff8110f585:	e8 66 6e 80 00       	callq  ffffffff819163f0 <mcount>
> > ffffffff8110f58a:	e8 61 6e 80 00       	callq  ffffffff819163f0 <mcount>
> > ffffffff8110f58f:	e8 5c 6e 80 00       	callq  ffffffff819163f0 <mcount>  
> 
> Your compiler is on drugs!

Totally agree!


[..]

> 
> > ffffffff8110f5fd:	4c 89 75 d0          	mov    %r14,-0x30(%rbp)
> > ffffffff8110f601:	ff 75 d0             	pushq  -0x30(%rbp)
> > ffffffff8110f604:	9d                   	popfq    
> 
> put r14 into -0x30(rbp) and pushes/pops that, see [*] this is 8 bytes
> over stack ?!

But from rbp, the stack is 0x40 bytes. This may be fine.

-- Steve