Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753016AbcCBTWN (ORCPT ); Wed, 2 Mar 2016 14:22:13 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:34269 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751482AbcCBTWL (ORCPT ); Wed, 2 Mar 2016 14:22:11 -0500 MIME-Version: 1.0 In-Reply-To: <20160302174052.GH29826@mtj.duckdns.org> References: <1456859137-13646-1-git-send-email-pandit.parav@gmail.com> <20160302174052.GH29826@mtj.duckdns.org> Date: Thu, 3 Mar 2016 00:52:08 +0530 Message-ID: Subject: Re: [PATCHv9 0/3] rdmacg: IB/core: rdma controller support From: Parav Pandit To: Tejun Heo Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, lizefan@huawei.com, Johannes Weiner , Doug Ledford , Liran Liss , "Hefty, Sean" , Jason Gunthorpe , Haggai Eran , Jonathan Corbet , james.l.morris@oracle.com, serge@hallyn.com, Or Gerlitz , Matan Barak , raindel@mellanox.com, akpm@linux-foundation.org, linux-security-module@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 33 Hi Tejun, On Wed, Mar 2, 2016 at 11:10 PM, Tejun Heo wrote: > Hello, Parav. > > It doesn't look like my reviews are getting through. For now, > I have addressed all the review comments that you provided in v5 patch. I admit that few comments have not followed CodingStyle and I owe to fix it, which is bad on my part. I have few 2 questions on your comments, I will ask there. For cgroup lock - out of 3 proposals, you acknowledged that you are ok with cgroup specific spin_lock, though you don't see that as big saving. Even though it can be made course gained by having single lock for the whole rdma cgroup subsystem it raises contention among processes of different cgroups, which is preferable to avoid. So I have continued to have cgroup specific fine grain lock, which I believe is ok as this is little efficient for first cut. Including above one we agreed on almost all the points at design and implementation level in previous patches. If you see any issue, I am open to resolve them. I will address comments given in patch v9. > Nacked-by: Tejun Heo > > Thanks. > > -- > tejun