Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755409AbcCBUqa (ORCPT ); Wed, 2 Mar 2016 15:46:30 -0500 Received: from mail.skyhub.de ([78.46.96.112]:47198 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753414AbcCBUq2 (ORCPT ); Wed, 2 Mar 2016 15:46:28 -0500 Date: Wed, 2 Mar 2016 21:46:22 +0100 From: Borislav Petkov To: "H. Peter Anvin" Cc: Brian Gerst , X86 ML , LKML , Tom Lendacky Subject: Re: [RFC PATCH] x86: Make sure verify_cpu has a good stack Message-ID: <20160302204622.GI8362@pd.tnic> References: <1456917606-4979-1-git-send-email-bp@alien8.de> <20160302162530.GA8362@pd.tnic> <086BE61B-DCCC-4105-90A2-295A487C7F6F@zytor.com> <20160302181556.GD8362@pd.tnic> <56D73349.3020609@zytor.com> <20160302195053.GG8362@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160302195053.GG8362@pd.tnic> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 606 Lines: 22 On Wed, Mar 02, 2016 at 08:50:53PM +0100, Borislav Petkov wrote: > But better safe than sorry. I got this, it looks good when I'm single-stepping through it with gdb and it boots fine in kvm. I'll run it on baremetal tomorrow: /* * Setup stack for verify_cpu(): make sure we don't clobber a valid * stack pointer by using temporary registers. */ movq stack_start(%rip), %rax movq $__START_KERNEL_map, %rdx subq %rdx, %rax movq %rax, %rsp Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.