Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752701AbcCBVPI (ORCPT ); Wed, 2 Mar 2016 16:15:08 -0500 Received: from dehamd003.servertools24.de ([31.47.254.18]:34872 "EHLO dehamd003.servertools24.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbcCBVPG (ORCPT ); Wed, 2 Mar 2016 16:15:06 -0500 X-Greylist: delayed 331 seconds by postgrey-1.27 at vger.kernel.org; Wed, 02 Mar 2016 16:15:06 EST Subject: Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine To: "Felipe F. Tonello" , linux-usb@vger.kernel.org References: <1456947640-20673-1-git-send-email-eu@felipetonello.com> <1456947640-20673-2-git-send-email-eu@felipetonello.com> Cc: linux-kernel@vger.kernel.org, Felipe Balbi , Michal Nazarewicz From: Clemens Ladisch Message-ID: <56D7567A.40402@ladisch.de> Date: Wed, 2 Mar 2016 22:09:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456947640-20673-2-git-send-email-eu@felipetonello.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-PPP-Message-ID: <20160302210932.567388.97981@dehamd003.servertools24.de> X-PPP-Vhost: ladisch.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 429 Lines: 15 Felipe F. Tonello wrote: > This refactor results in a cleaner state machine code It increases the number of states, and now juggles two state variables. I cannot agree to it being cleaner. > and as a result fixed a bug when packaging a USB-MIDI packet right after > a non-conformant MIDI byte stream. I have been unable to determine where exactly the new code behaves differently. Can you show an example? Regards, Clemens