Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754256AbcCBVqo (ORCPT ); Wed, 2 Mar 2016 16:46:44 -0500 Received: from mleia.com ([178.79.152.223]:60301 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752727AbcCBVqm (ORCPT ); Wed, 2 Mar 2016 16:46:42 -0500 Subject: Re: [PATCHv7 3/7] eeprom: at24: extend driver to plug into the NVMEM framework To: Andrew Lunn References: <1456516764-1456-1-git-send-email-andrew@lunn.ch> <1456516764-1456-4-git-send-email-andrew@lunn.ch> Cc: GregKH , srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com, wsa@the-dreams.de, broonie@kernel.org, linux-kernel@vger.kernel.org, pantelis.antoniou@konsulko.com, bgolaszewski@baylibre.com From: Vladimir Zapolskiy Message-ID: <56D75F3F.5000806@mleia.com> Date: Wed, 2 Mar 2016 23:46:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1456516764-1456-4-git-send-email-andrew@lunn.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20160302_214954_797735_91AB1F16 X-CRM114-Status: GOOD ( 14.81 ) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1328 Lines: 56 Hi Andrew, On 26.02.2016 21:59, Andrew Lunn wrote: > Add a regmap for accessing the EEPROM, and then use that with the > NVMEM framework. Set the NVMEM config structure to enable backward, so > that the 'eeprom' file in sys is provided by the framework. > > Signed-off-by: Andrew Lunn > Acked-by: Srinivas Kandagatla > Tested-by: Bartosz Golaszewski > --- [snip] > +static int at24_regmap_read(void *context, const void *reg, size_t reg_size, > + void *val, size_t val_size) > +{ > + struct at24_data *at24 = context; > + off_t offset = *(u32 *)reg; > + int err; > + > + err = at24_read(at24, val, offset, val_size); > + if (err) > + return err; > + return 0; return at24_read(at24, val, offset, val_size); Minus 5 LoC. > +} > + > +static int at24_regmap_write(void *context, const void *data, size_t count) > +{ > + struct at24_data *at24 = context; > + const char *buf; > + u32 offset; > + size_t len; > + int err; > + > + memcpy(&offset, data, sizeof(offset)); > + buf = (const char *)data + sizeof(offset); > + len = count - sizeof(offset); > + > + err = at24_write(at24, buf, offset, len); > + if (err) > + return err; > + return 0; return at24_write(at24, buf, offset, len); Minus another 5 LoC. -- With best wishes, Vladimir