Message-ID: <56D76138.1010606@hpe.com>
Date: Wed, 2 Mar 2016 16:55:04 -0500
From: Waiman Long <waiman.long@hpe.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12
MIME-Version: 1.0
To: Ingo Molnar <mingo@kernel.org>
CC: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.com>,
        Jeff Layton <jlayton@poochiereds.net>,
        "J. Bruce Fields" <bfields@fieldses.org>, Tejun Heo <tj@kernel.org>,
        Christoph Lameter <cl@linux-foundation.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Andi Kleen <andi@firstfloor.org>, Dave Chinner <dchinner@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        Scott J Norton <scott.norton@hp.com>,
        Douglas Hatch <doug.hatch@hp.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH v5 5/5] lib/percpu-list: Add a config parameter for disabling
 per-cpu list
References: <1456866003-32441-1-git-send-email-Waiman.Long@hpe.com> <1456866003-32441-6-git-send-email-Waiman.Long@hpe.com> <20160302084128.GA21779@gmail.com>
In-Reply-To: <20160302084128.GA21779@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2016 21:55:13.8107 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0307
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1581
Lines: 40

On 03/02/2016 03:41 AM, Ingo Molnar wrote:
> * Waiman Long<Waiman.Long@hpe.com>  wrote:
>
>> As there is concern that the larger pcpu_list_node structure and the
>> per-cpu overhead may be a waste of resource on small system. This patch
>> adds a config parameter CONFIG_PERCPU_LIST to disable the per-cpu list
>> if the kernel builder chooses to do so. With per-cpu list disabled,
>> all the different groups of per-cpu lists will be degenerated into
>> global lists for all the CPUs.
>>
>> The current default is to enable per-cpu list. A kernel builder needs
>> to explicitly turn it off.
>>
>> Signed-off-by: Waiman Long<Waiman.Long@hpe.com>
>> ---
>>   fs/inode.c                  |    2 +-
>>   include/linux/percpu-list.h |   93 ++++++++++++++++++++++++++++++++++++++++++-
>>   lib/Kconfig                 |   14 ++++++
>>   lib/percpu-list.c           |   24 +++++++++++-
>>   4 files changed, 130 insertions(+), 3 deletions(-)
> I think this kind of #ifdef complexity and the doubling of our Kconfig and testing
> space is counterproductive, and I think the per CPU locking is a win on as small
> as dual core CPUs, and on UP CPUs the per CPU list becomes a single global list
> automatically.
>
> I'm not against visible memory savings for overly clever scalability features, but
> this does not appear to be such a case, so:
>
> NAKed-by: Ingo Molnar<mingo@kernel.org>
>
> Thanks,
>
> 	Ingo

The last patch was there to answer a feedback from Jan. I am fine if 
that is not merged as I prefer to have the per-cpu list capability as 
the default anyway.

Cheers,
Longman