Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754887AbcCBV4U (ORCPT ); Wed, 2 Mar 2016 16:56:20 -0500 Received: from mleia.com ([178.79.152.223]:60333 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753543AbcCBV4T (ORCPT ); Wed, 2 Mar 2016 16:56:19 -0500 Subject: Re: [PATCHv7 5/7] eeprom: at25: extend driver to plug into the NVMEM framework To: Andrew Lunn References: <1456516764-1456-1-git-send-email-andrew@lunn.ch> <1456516764-1456-6-git-send-email-andrew@lunn.ch> Cc: GregKH , srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com, wsa@the-dreams.de, broonie@kernel.org, linux-kernel@vger.kernel.org, pantelis.antoniou@konsulko.com, bgolaszewski@baylibre.com From: Vladimir Zapolskiy Message-ID: <56D76180.1050205@mleia.com> Date: Wed, 2 Mar 2016 23:56:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1456516764-1456-6-git-send-email-andrew@lunn.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20160302_215932_018776_B1E3B381 X-CRM114-Status: GOOD ( 16.92 ) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1942 Lines: 77 Hi Andrew, On 26.02.2016 21:59, Andrew Lunn wrote: > Add a regmap for accessing the EEPROM, and then use that with the > NVMEM framework. Enable backwards compatibility in the NVMEM config, > so that the 'eeprom' file in sys is provided by the framework. > > Signed-off-by: Andrew Lunn > Acked-by: Srinivas Kandagatla > --- [snip] > > -static ssize_t > -at25_bin_read(struct file *filp, struct kobject *kobj, > - struct bin_attribute *bin_attr, > - char *buf, loff_t off, size_t count) > +static int at25_regmap_read(void *context, const void *reg, size_t reg_size, > + void *val, size_t val_size) > { > - struct device *dev; > - struct at25_data *at25; > - > - dev = kobj_to_dev(kobj); > - at25 = dev_get_drvdata(dev); > + struct at25_data *at25 = context; > + off_t offset = *(u32 *)reg; > + int err; > > - return at25_ee_read(at25, buf, off, count); > + err = at25_ee_read(at25, val, offset, val_size); > + if (err) > + return err; > + return 0; return at25_ee_read(at25, val, offset, val_size); > } > [snip] > > -static ssize_t > -at25_bin_write(struct file *filp, struct kobject *kobj, > - struct bin_attribute *bin_attr, > - char *buf, loff_t off, size_t count) > +static int at25_regmap_write(void *context, const void *data, size_t count) > { > - struct device *dev; > - struct at25_data *at25; > + struct at25_data *at25 = context; > + const char *buf; > + u32 offset; > + size_t len; > + int err; > > - dev = kobj_to_dev(kobj); > - at25 = dev_get_drvdata(dev); > + memcpy(&offset, data, sizeof(offset)); > + buf = (const char *)data + sizeof(offset); > + len = count - sizeof(offset); > > - return at25_ee_write(at25, buf, off, count); > + err = at25_ee_write(at25, buf, offset, len); > + if (err) > + return err; > + return 0; return at25_ee_write(at25, buf, offset, len) is shorter. > } -- With best wishes, Vladimir