Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121AbcCBXVs (ORCPT ); Wed, 2 Mar 2016 18:21:48 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58894 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbcCBXVr (ORCPT ); Wed, 2 Mar 2016 18:21:47 -0500 Date: Wed, 2 Mar 2016 15:21:46 -0800 From: Greg KH To: green@linuxhacker.ru Cc: devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH] staging/lustre: Unbreak ll_prep_inode iget result check Message-ID: <20160302232146.GA24687@kroah.com> References: <1456925139-1058929-1-git-send-email-green@linuxhacker.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456925139-1058929-1-git-send-email-green@linuxhacker.ru> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 755 Lines: 19 On Wed, Mar 02, 2016 at 08:25:39AM -0500, green@linuxhacker.ru wrote: > From: Oleg Drokin > > commit 020ecc6f3229 ("staging: lustre: llite: Remove IS_ERR tests") > managed to break one of the converted checks by losing a dereference > causing the condition to be wrong and hence leading > to a crash later on in case of actual error. > IS_ERR_OR_NULL(*inode) got converted into !inode. > > Signed-off-by: Oleg Drokin > CC: Amitoj Kaur Chawla > --- > I am not sure where did that patch came from as I cannot see > it in either my inbox or in any public mailinglists via google. My fault, it is part of the Outreachy application process, I missed that bug, sorry about this. greg k-h