Date: Thu, 3 Mar 2016 13:43:14 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 2/2] objtool: Support CROSS_COMPILE
Message-ID: <20160303134314.7098f033@canb.auug.org.au>
In-Reply-To: <55b63eefc347f1bb28573f972d8d1adbf1f1c31d.1456962210.git.jpoimboe@redhat.com>
References: <20160303092134.7c750589@canb.auug.org.au>
	<cover.1456962210.git.jpoimboe@redhat.com>
	<55b63eefc347f1bb28573f972d8d1adbf1f1c31d.1456962210.git.jpoimboe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 712
Lines: 28

Hi Josh,

Just a couple of quick comments ...

On Wed,  2 Mar 2016 18:39:37 -0600 Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
> index c4f0713..e4a6bd5 100644
> --- a/tools/objtool/Makefile
> +++ b/tools/objtool/Makefile

I was wondering if this would be more appropriate in scripts/objtool
since it is used during the building of the kernel.  Or does it have a
wider use?

> @@ -7,13 +7,19 @@ ARCH := x86
>  endif
>  endif
>  
> +# always use the host compiler
> +CC = gcc

We have HOSTCC with its associated HOSTCFLAGS etc ... I am not sure if
that is more appropriate (but it does take care of people using clang).

-- 
Cheers,
Stephen Rothwell