Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756369AbcCCDXh (ORCPT ); Wed, 2 Mar 2016 22:23:37 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33763 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425AbcCCDXf (ORCPT ); Wed, 2 Mar 2016 22:23:35 -0500 Date: Wed, 2 Mar 2016 19:23:27 -0800 From: Eduardo Valentin To: Javi Merino Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, rui.zang@intel.com, Zhang Rui Subject: Re: [PATCH v3 1/4] thermal: Add support for hierarchical thermal zones Message-ID: <20160303032326.GE3379@localhost.localdomain> References: <1448464186-26289-1-git-send-email-javi.merino@arm.com> <1448464186-26289-2-git-send-email-javi.merino@arm.com> <20160303031244.GA3379@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160303031244.GA3379@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 520 Lines: 18 On Wed, Mar 02, 2016 at 07:12:46PM -0800, Eduardo Valentin wrote: > > Thanks for moving this forward Javi, > > Few comments inline. > > On Wed, Nov 25, 2015 at 03:09:43PM +0000, Javi Merino wrote: > > Add the ability to stack thermal zones on top of each other, creating a > > hierarchy of thermal zones. > > + > > + if (!tz->ops->get_temp) { > > + ret = get_subtz_temp(tz, temp); > > + goto unlock; > > + } In fact, if we follow the semantics in DT, we should allow both, regular sensors (.get_temp) and subtzs.