Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754888AbcCCDqJ (ORCPT ); Wed, 2 Mar 2016 22:46:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42322 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891AbcCCDqH (ORCPT ); Wed, 2 Mar 2016 22:46:07 -0500 Date: Wed, 2 Mar 2016 21:46:05 -0600 From: Josh Poimboeuf To: Stephen Rothwell Cc: Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Adrian Hunter , Michael Ellerman , Peter Zijlstra , Thomas Gleixner , "H. Peter Anvin" Subject: Re: [PATCH 2/2] objtool: Support CROSS_COMPILE Message-ID: <20160303034605.GB10338@treble.redhat.com> References: <20160303092134.7c750589@canb.auug.org.au> <55b63eefc347f1bb28573f972d8d1adbf1f1c31d.1456962210.git.jpoimboe@redhat.com> <20160303134314.7098f033@canb.auug.org.au> <20160303032058.GA10338@treble.redhat.com> <20160303143843.6eaf80b5@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160303143843.6eaf80b5@canb.auug.org.au> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1592 Lines: 40 On Thu, Mar 03, 2016 at 02:38:43PM +1100, Stephen Rothwell wrote: > Hi Josh, > > On Wed, 2 Mar 2016 21:20:58 -0600 Josh Poimboeuf wrote: > > > > On Thu, Mar 03, 2016 at 01:43:14PM +1100, Stephen Rothwell wrote: > > > > > > I was wondering if this would be more appropriate in scripts/objtool > > > since it is used during the building of the kernel. Or does it have a > > > wider use? > > > > Yeah, it was actually in the scripts/ dir in earlier revisions of the > > patch set, for that very reason. However, Ingo pointed out that it > > could be useful beyond the kernel, so we graduated it to a "tool". > > > > > > > > We have HOSTCC with its associated HOSTCFLAGS etc ... I am not sure if > > > that is more appropriate (but it does take care of people using clang). > > > > The "tools" are almost completely separate from the rest of the kernel. > > They have their own scaled-down version of kbuild, which doesn't have > > HOSTCC. > > > > But yeah, we might eventually need to copy some of the host compilation > > infrastructure from scripts/Makefile.host over to the tools/ side. > > That all sounds sane, thanks. > > I did not add this to linux-next today, but may tomorrow if people > think it is sensible to do so (for testing on a powerpcle host). If I > do, I will just back out to the previous patch if it all goes south (so > it won't impact on the rest of the tip tree's testing). Sounds good, thanks! FWIW, I did test it on a ppc64le host with an x86 cross-compiler and it worked fine (but more testing is certainly welcome). -- Josh