Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524AbcCCEKg (ORCPT ); Wed, 2 Mar 2016 23:10:36 -0500 Received: from mail-oi0-f52.google.com ([209.85.218.52]:35555 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754157AbcCCEKf (ORCPT ); Wed, 2 Mar 2016 23:10:35 -0500 MIME-Version: 1.0 In-Reply-To: <1456975950.4044.92.camel@perches.com> References: <1456975950.4044.92.camel@perches.com> From: Jianyu Zhan Date: Thu, 3 Mar 2016 12:09:55 +0800 Message-ID: Subject: Re: about get_maintainer.pl not showing the original author of the modified code To: Joe Perches Cc: LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2479 Lines: 44 On Thu, Mar 3, 2016 at 11:32 AM, Joe Perches wrote: > with your patch get_maintainer.pl and --git-blame gives: > > $ ./scripts/get_maintainer.pl ~/1.diff --git-blame > Thomas Gleixner (commit_signer:20/19=100%,authored:7/19=37%,added_lines:73/248=29%,removed_lines:38/119=32%) > Peter Zijlstra (commit_signer:3/19=16%,authored:1/19=5%) > Andrew Morton (commit_signer:3/19=16%,modified commits:2/3=67%) > Davidlohr Bueso (commit_signer:3/19=16%,authored:3/19=16%,added_lines:113/248=46%,removed_lines:20/119=17%) > Ingo Molnar (commit_signer:2/19=11%,modified commits:2/3=67%) > Dominik Dingel (authored:1/19=5%) > Jann Horn (authored:1/19=5%) > Sebastian Andrzej Siewior (added_lines:29/248=12%) > "Kirill A. Shutemov" (added_lines:14/248=6%,removed_lines:49/119=41%) > Darren Hart (modified commits:1/3=33%) > Stephen Hemminger (modified commits:1/3=33%) > Christian Borntraeger (modified commits:1/3=33%) > linux-kernel@vger.kernel.org (open list) > > vs > > $ ./scripts/get_maintainer.pl ~/1.diff > Thomas Gleixner (commit_signer:20/19=100%,authored:7/19=37%,added_lines:73/248=29%,removed_lines:38/119=32%) > Davidlohr Bueso (commit_signer:3/19=16%,authored:3/19=16%,added_lines:113/248=46%,removed_lines:20/119=17%) > Peter Zijlstra (commit_signer:3/19=16%) > Andrew Morton (commit_signer:3/19=16%) > Ingo Molnar (commit_signer:2/19=11%) > Rasmus Villemoes (authored:1/19=5%) > Darren Hart (authored:1/19=5%) > kbuild test robot (authored:1/19=5%) > Sebastian Andrzej Siewior (added_lines:29/248=12%) > "Kirill A. Shutemov" (added_lines:14/248=6%,removed_lines:49/119=41%) So original author's email would be spit out only if given --git-blame, instead of by default, which really surprises people. Since most time we will cc original author, we have to use --git-blame explicitly, thus pay the running time cost. So the runtime argument don't stands, why not just enable it by default? Regards, Jianyu Zhan