Message-ID: <1456979077.4044.106.camel@perches.com>
Subject: Re: about get_maintainer.pl not showing the original author of the
 modified code
From: Joe Perches <joe@perches.com>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Date: Wed, 02 Mar 2016 20:24:37 -0800
In-Reply-To: <CAHz2CGU7USf=sqtfkbwq0bGRwkyj1deRQ=eQ1ttT=396J_zOQg@mail.gmail.com>
References: <CAHz2CGUwWchcK+6nKcwbiETku5zBP7AuF0HqAmk5j-9=KnwTFQ@mail.gmail.com>
	 <1456975950.4044.92.camel@perches.com>
	 <CAHz2CGU7USf=sqtfkbwq0bGRwkyj1deRQ=eQ1ttT=396J_zOQg@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2881
Lines: 52

On Thu, 2016-03-03 at 12:09 +0800, Jianyu Zhan wrote:
> On Thu, Mar 3, 2016 at 11:32 AM, Joe Perches <joe@perches.com> wrote:
> > 
> > with your patch get_maintainer.pl and --git-blame gives:
> > 
> > $ ./scripts/get_maintainer.pl ~/1.diff --git-blame
> > Thomas Gleixner <tglx@linutronix.de> (commit_signer:20/19=100%,authored:7/19=37%,added_lines:73/248=29%,removed_lines:38/119=32%)
> > Peter Zijlstra <peterz@infradead.org> (commit_signer:3/19=16%,authored:1/19=5%)
> > Andrew Morton <akpm@linux-foundation.org> (commit_signer:3/19=16%,modified commits:2/3=67%)
> > Davidlohr Bueso <dave@stgolabs.net> (commit_signer:3/19=16%,authored:3/19=16%,added_lines:113/248=46%,removed_lines:20/119=17%)
> > Ingo Molnar <mingo@kernel.org> (commit_signer:2/19=11%,modified commits:2/3=67%)
> > Dominik Dingel <dingel@linux.vnet.ibm.com> (authored:1/19=5%)
> > Jann Horn <jann@thejh.net> (authored:1/19=5%)
> > Sebastian Andrzej Siewior <bigeasy@linutronix.de> (added_lines:29/248=12%)
> > "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> (added_lines:14/248=6%,removed_lines:49/119=41%)
> > Darren Hart <dvhart@linux.intel.com> (modified commits:1/3=33%)
> > Stephen Hemminger <shemminger@linux-foundation.org> (modified commits:1/3=33%)
> > Christian Borntraeger <borntrae@de.ibm.com> (modified commits:1/3=33%)
> > linux-kernel@vger.kernel.org (open list)
> > 
> > vs
> > 
> > $ ./scripts/get_maintainer.pl ~/1.diff
> > Thomas Gleixner <tglx@linutronix.de> (commit_signer:20/19=100%,authored:7/19=37%,added_lines:73/248=29%,removed_lines:38/119=32%)
> > Davidlohr Bueso <dave@stgolabs.net> (commit_signer:3/19=16%,authored:3/19=16%,added_lines:113/248=46%,removed_lines:20/119=17%)
> > Peter Zijlstra <peterz@infradead.org> (commit_signer:3/19=16%)
> > Andrew Morton <akpm@linux-foundation.org> (commit_signer:3/19=16%)
> > Ingo Molnar <mingo@kernel.org> (commit_signer:2/19=11%)
> > Rasmus Villemoes <linux@rasmusvillemoes.dk> (authored:1/19=5%)
> > Darren Hart <dvhart@linux.intel.com> (authored:1/19=5%)
> > kbuild test robot <fengguang.wu@intel.com> (authored:1/19=5%)
> > Sebastian Andrzej Siewior <bigeasy@linutronix.de> (added_lines:29/248=12%)
> > "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> (added_lines:14/248=6%,removed_lines:49/119=41%)
> 
> So original author's email would be spit out only if given
> --git-blame, instead of by default,
> which really surprises people.??Since most time we will cc original
> author,??we have to use
> --git-blame explicitly, thus pay the running time cost. So the runtime
> ?argument don't stands,
> why not just enable it by default?

Several reasons:

Most of the time, git history isn't used at all
because there is a specific named maintainer.

history isn't always appropriate as the original
authors email address is old and bounces

a .get_maintainer.conf file can be used to set
whatever defaults anyone prefers.