Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757038AbcCCIPa (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Mar 2016 03:15:30 -0500
Received: from mail-am1on0058.outbound.protection.outlook.com ([157.56.112.58]:15418
	"EHLO emea01-am1-obe.outbound.protection.outlook.com"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1756960AbcCCIPU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Mar 2016 03:15:20 -0500
Authentication-Results: spf=pass (sender IP is 193.47.165.134)
 smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed)
 header.d=none;vger.kernel.org; dmarc=pass action=none
 header.from=mellanox.com;
Subject: Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller
To: Parav Pandit <pandit.parav@gmail.com>, Tejun Heo <tj@kernel.org>
References: <1456859137-13646-1-git-send-email-pandit.parav@gmail.com>
 <1456859137-13646-2-git-send-email-pandit.parav@gmail.com>
 <20160302173949.GG29826@mtj.duckdns.org>
 <CAG53R5UAmTP9-m77-j2tPGZ+z8AicuVvUB_++cRUbQY-EwaBYw@mail.gmail.com>
 <CAG53R5WcbE8Hesb2sh6xg1fRLBOBt+VFo0L3U6WLPr3irtko8w@mail.gmail.com>
CC: <cgroups@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
        <lizefan@huawei.com>, Johannes Weiner <hannes@cmpxchg.org>,
        Doug Ledford <dledford@redhat.com>, Liran Liss <liranl@mellanox.com>,
        "Hefty, Sean" <sean.hefty@intel.com>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Jonathan Corbet <corbet@lwn.net>, <james.l.morris@oracle.com>,
        <serge@hallyn.com>, Or Gerlitz <ogerlitz@mellanox.com>,
        Matan Barak <matanb@mellanox.com>, <raindel@mellanox.com>,
        <akpm@linux-foundation.org>, <linux-security-module@vger.kernel.org>
From: Haggai Eran <haggaie@mellanox.com>
Message-ID: <56D7F27D.1040702@mellanox.com>
Date: Thu, 3 Mar 2016 10:14:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <CAG53R5WcbE8Hesb2sh6xg1fRLBOBt+VFo0L3U6WLPr3irtko8w@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.0.52.254]
X-EOPAttributedMessage: 0
X-Forefront-Antispam-Report: CPI:193.47.165.134;IPV:NLI;CTRY:IL;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(479174004)(24454002)(189002)(377454003)(199003)(230700001)(1220700001)(50466002)(3846002)(92566002)(33656002)(1096002)(6116002)(586003)(2906002)(64126003)(23676002)(76176999)(87936001)(83506001)(5008740100001)(87266999)(189998001)(93886004)(4326007)(54356999)(5004730100002)(50986999)(77096005)(86362001)(19580395003)(5001770100001)(36756003)(5001960100004)(80316001)(19580405001)(65806001)(106466001)(65956001)(2950100001)(4001350100001)(65816999)(47776003)(6806005)(11100500001)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR05MB473;H:mtlcas13.mtl.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en;
X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD045;1:p/3Vbi8KOu6mkaAgD+6mETwsAcHDV13GVJE9SyC26UACJRMjLDFc358i3WC/+4Hl72/ZHyIg6UHod7tmugw0vAKPI7vj2+VBeR3p7aCyk8dNxmKRlejGnnLY+/IqMXHxmjiLEHENux6uY2SIL8KlXImnZ/tba6zGNOoBA4drGSNBA2UXxVuuseSbz+ieWKUYsIZ+7I5SqoXcEE8Rz1Ver8krGMQS3VZvx5Fgzd+Hq3y4al0Dt/mmr7wUcY4Ip/RKWRpurrpV1RhfCjz1vrmTPeTfiMuryKggO1d5oeM5OuhbFnMkQ3j8EcG7WvEvNOQEsCNe/Soxj7a60xztptQynTOxi2O4V4AGaqnQljZjM4BCQr0KBj2MYuFlf9IG3i+nzAd/XTDQgWB+lP9uwf1ONArxZiOYLH9oNJrMNQxYimIcvp2u94+q2uqFEKQUDQlQYegtRuILKGikB0mSXL4YsHRbNOYSoqrQUZZ4FlZG/RK/+NVlLIJ/xnRkpEohDj2+
X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB473;2:JeAr2Snt5z6aSMNL80WPc8xBGOLTvWyrls+ZboyPTSd/b/PXbxdgUsSByy78EKAGG8j+ZDEsFkZMMduR3AvIUG+NzpVYBQkC68mu/D9WN/nlRKhwWWSJTPwkyMh8aELVgzyig95cb8FkRVu9L0zvsQ==;3:qo2STIiMUYtiiSpw73D2Li4fBt3QWtThpYmEyyLDtJVaC+1/f3JmUyzHhTtrsT6N4VfyPa3eyYki9PaFf6wXqWyS2DkMQYsul/IXzH439KZb3wsf7EEGuGPdCJ62Ax+y+yEKKG3SQgCGnoEfR+IySw/iS5UJgKPi6r/1bq2EtCQjUo3mW9U0UI68YnUJ1zdUtzqDaK1meoXz2hJcPQL8WQ==;25:zoNRftj4KJrsDJ1/EdWe2mbn8KemdiFYar4vERp/xPEpcTFDdVrkp0S9VHsTvX53GZ9kXGBgU8aiZkuXOXGhec14R26NCHfC+EZJCQVv2IhS3U1UEZz8JN8MEphUeNPa+0fr+CDCeq4OPoKaOBa2ID83PQEWM2Pwz92poveKY/b7+pnrcP+y/AnNBcc7M3vaojKuiJElWYA/cd5f+fLfUw/N97UhM8n2Yiiro7fozttHMHazRhkcE6Stx7xHcBqhB8YdVTiy7wT7xnOeeD9U0FRkkJPsbH9ipi/E5tnPy7ZWvA12/8qeQ+6dpvpPtVMwJL+1OGBDYDwrnm+4hvFP9Q==
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:DB3PR05MB473;
X-MS-Office365-Filtering-Correlation-Id: bacfc886-9041-457c-0f82-08d3433bf242
X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB473;20:Sf+Eu5vdArY+BNPHmkKlMch5QVUqAbNduxfPljhgH3LPOE88gKLRwTUp1kUS3oNtNU8o5uthcJLKllWYxiOpVgIoob2dMDqQHBTctFUOhGZcfXubloRRDeWPkOI6ziZJE2cBpr+hFQZPaN4qXG3IJe/5M1n5c75S5fMHZshpjn/PnDIj0tZoiUscbpGsnYwSZokrD8u1bJvsK7bOP3sr36Zl2Ny1N5pWDua0aoUhtQv3zsarIC5/Hyuoim668RmZ/uF4X+xXK7w5Nnbto+8o1CtvtNYjq7xWu56fHMfUimroWYlSB8hpAiN3w/+FLRWeRPvYg6SOfeo/nDX/DxCnqD9UgKtVX0WstM8j+Pr3Sb69cyshXB3THepdqnaQl5+oSOEfqsbz/c7KQNUL86jTgRUAV6cjvX3AO2gqp82x4OYLhPZkJTtMA2IBEw/hskW1ctFDo64AMY1776WJ/QlCsgytn76v3S5wlqKWXknT+LAXKu+NpBY8ZoeuPIt59Ldv
X-Microsoft-Antispam-PRVS: <DB3PR05MB4739D1E26961E4D16EE8CBFC1BD0@DB3PR05MB473.eurprd05.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(13018025)(13024025)(13015025)(13017025)(13023025)(3002001)(10201501046);SRVR:DB3PR05MB473;BCL:0;PCL:0;RULEID:;SRVR:DB3PR05MB473;
X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB473;4:AXadXFJ1osNaDsowDbUZfu7siSUTu35m7VaEe0RbC1QZljPaDq0zT6Ao6G/UAwLiXEHqA8PpIcrAp03bQSFuCaGNI8QSnPR0r2oTJOw+S8bzRgl0VEbyffIvEkkXhcjhGInKc/eVKPkn8OPK3USfW6bZesW58vi8Ymdj/uw/UsPQ53pYRAjtLfNrBpIZYlmuE9p+4xp9+UuNGNLTYYa21DsaojXdt8k+4f07SNxOBjeGL+Qcab4V00SwS1ZDQVesIczLZnQWGnMZaYZCfpUIqKUMuXb3Ls6OUhe0jDSLQ8tRCNmH5MkWXWf8Ot4lUb/9Eszz+bD1uMATrSFNKdx2aHPuuScAtNcpuS8YdoBiCAAo6DMD43oragDgtW6he4St7knkDl+6VtFIp7l5akeJRr49oXwKMkTH2n3jbL6FaNejfJTaSxkj4l+cNEf7I8OvmFkqDA2o2MNdq5yqeroIZg==
X-Forefront-PRVS: 0870212862
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjNQUjA1TUI0NzM7MjM6Z3ovSUZyR3p5cExLeDZRWEtHbjIxU3d3alFi?=
 =?utf-8?B?OEZMckFmNUpJa2d3WXJNcDJ6MTBCUDJJM0NtS0VURU9tV3dWbDhQYXRRNXkz?=
 =?utf-8?B?VXNTc2xMY1RPSWxLcjliclNjT2RaaitLV3gwTjRUM2JLajc5MVJJdHV5UUhi?=
 =?utf-8?B?VjB0RS9ZRjQ2TlVFWXpEclRPMHVHcDFzaUF1YWpYTWgzeThEdjYyVVBNSlFl?=
 =?utf-8?B?MWlQcExIMkpsVFcxdWs4NWN5MTlaNzlDZVgwbkRyUHZaK09lTmxSS1lobmNE?=
 =?utf-8?B?VmRXeng2MFZjZDlJVERSaWI1UlRDV2czU3RBd2J1TzVBWWNHMEtNYVY4am9y?=
 =?utf-8?B?V3VFdjRnTTZqaXBndEh5WVh6UkkvekpMRG5teldsU28vVkxnVVlWY0tqaVNP?=
 =?utf-8?B?QzNqcllXMVB6b0VhaFh6em9CSFhmUXZNUDVmVWpEY3BnU2FleXY0ZFBkd3FZ?=
 =?utf-8?B?emowLzBma1Z3aXhCdkxZVjNPaUJDaS8xd01zWHRQVFJQT1ZieUJBNHFCY3Jr?=
 =?utf-8?B?ZXR0K09ZeE1YY3ZtTmdmRWJ1aXlHcXo3SUNpZTNEYjAwOCt6UDJYTmVoajds?=
 =?utf-8?B?MzVDTS9VeVM3eVlXNTlWSy9JV3E3YmlVY1hqTUk1NXpwMmk1R2lnSFk2eEVi?=
 =?utf-8?B?SEt6Tm9wTHFPY3pNbUJBYmROSmtjK0E3WEZ4ZnE2TDA2RFBrQWpqME5jRnJL?=
 =?utf-8?B?cjY2M3RJOU1nUXd6YmNyejI3bnp2Ynh4T0Z2c2N0Zk5lQ0tIR0ZrUGhQSTJ1?=
 =?utf-8?B?YXVUNkxweDBWQjc5YktvSy9BaFhKb3hTY1dETUZhNzBhQjlhNjRPMGpCQzJR?=
 =?utf-8?B?YUkvdzFlRjBIRW00UmYzQldxUlRHd21CRU54bVpTNUpLK0tRWTJRNW9iUVh6?=
 =?utf-8?B?aGpuN3Bjc09pUklvZ0RWNHcyWDBRR08vK2p6TEc5NGlHVG5OZm14WVBHU1pv?=
 =?utf-8?B?a0tMMS9IZGUzbUx2VW1yZmFOTm05SGo3L0ZFNENPM2ZsVGVTVWxPZ29lVHp2?=
 =?utf-8?B?Z3ZhWE9VSllBcm5UdmlVazRTRTQ1T2dGM3lFN0E1a3NZMm1XVFZlY2MvTllJ?=
 =?utf-8?B?M2hUbE0wbTh6ZzdBaEhXTS9SaTl5SUU5Q285d2RnNS96Q0toOEt4Tzd6Tlla?=
 =?utf-8?B?RkpHSEdwbTBkTnlwcHpGNmZVR0YxMGJReFV3TlZQMUNpRkwrcWw2REV0bndN?=
 =?utf-8?B?dEJiUEM5d09LaDZCYlB5THZqYjdmQmUzbGJ5L1ZvNUU1bytoaHdRV1RCR1BK?=
 =?utf-8?B?NGZma2RORVZFV21qQ0tPcGp3MXpmdGR4VVNwdWpyQUMvcGt5UndPb1R5RXR1?=
 =?utf-8?B?TWxFQXhmUmxRUS9zSmczTmtNU3lxckkzdlBhUDRaUEVFcS8xblNPK0FnMFBO?=
 =?utf-8?B?Q1ZVM2pDYTk0OHUrME9QRFUxSkxMQjdmQmUzUG1pUGpUVVNGNzRkUnRtb0RE?=
 =?utf-8?B?b2xnazFlZERwc3ZheEg0dTIxcU1hTXZBSjM5bGxFc29zcG5qZUd5U2hqZXRV?=
 =?utf-8?B?cXdFTVVaSFNaelV1R1hlVm1HaHl5cE5mQjdOSjdyN2xyUWtMcUZiRUtENHlT?=
 =?utf-8?B?NUhoWk9YbHBuMUlsNlpQVGRnR2szSURrUXFnYmVlZzNQck1RVHBOOVorWGJM?=
 =?utf-8?B?WFM3aDdrbkpiLzdlSk9KY2NuUjRzNk5pUm15d0tFYUJxYkpEVE8yM0U0cnF6?=
 =?utf-8?Q?sCuXTAl4z0auEiMXU=3D?=
X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB473;5:rRCHdsW3o2Z77HCSD2MdpK2YhvhiSh2ref1Lsbqkrx+DzgKvBcZaCaIT9bxQ5pwKH8puhTXFN9qYSL3MTaQQZnXyJ7WAl05yKarieZfpUAz3d9VzKhSXYMaLn8kTvKun7uFRhQIHRJfZQh+i8vfV9g==;24:IoB3q3STJGlakETNKnjZeOCEYIZ1W/uiZhbN5Zw+K/7EAa9YnJIG6cYTf0uiu0TLKgDCIZ/Buw4T/jmftMOc9tYSp/qcAX6L4DY8s485J18=
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2016 08:15:13.3266
 (UTC)
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR05MB473
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 589
Lines: 11

On 03/03/2016 05:18, Parav Pandit wrote:
> On Thu, Mar 3, 2016 at 1:28 AM, Parav Pandit <pandit.parav@gmail.com> wrote:
>> On Wed, Mar 2, 2016 at 11:09 PM, Tejun Heo <tj@kernel.org> wrote:
>>> Nothing seems to prevent @cg from going away if this races with
>>> @current being migrated to a different cgroup.  Have you run this with
>>> lockdep and rcu debugging enabled?  This should have triggered a
>>> warning.
> I am able to reproduce this race. Looking into how to address it.

If I understand correctly, task_css() requires rcu read lock being held.
Is task_get_css() suitable here?