Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757329AbcCCK3w (ORCPT ); Thu, 3 Mar 2016 05:29:52 -0500 Received: from www262.sakura.ne.jp ([202.181.97.72]:57758 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753196AbcCCK3v (ORCPT ); Thu, 3 Mar 2016 05:29:51 -0500 To: mhocko@kernel.org, js1304@gmail.com Cc: iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, hughd@google.com, torvalds@linux-foundation.org, hannes@cmpxchg.org, mgorman@suse.de, rientjes@google.com, hillf.zj@alibaba-inc.com, kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sergey.senozhatsky.work@gmail.com Subject: Re: [PATCH 0/3] OOM detection rework v4 From: Tetsuo Handa References: <20160302095056.GB26701@dhcp22.suse.cz> <20160302140611.GI26686@dhcp22.suse.cz> <20160303092634.GB26202@dhcp22.suse.cz> In-Reply-To: <20160303092634.GB26202@dhcp22.suse.cz> Message-Id: <201603031929.CCI95349.HOMQOOtJFFVLFS@I-love.SAKURA.ne.jp> X-Mailer: Winbiff [Version 2.51 PL2] X-Accept-Language: ja,en,zh Date: Thu, 3 Mar 2016 19:29:47 +0900 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 642 Lines: 12 Michal Hocko wrote: > Sure we can be more intelligent and reset the counter if the > feedback from compaction is optimistic and we are making some > progress. This would be less hackish and the XXX comment points into > that direction. For now I would like this to catch most loads reasonably > and build better heuristics on top. I would like to do as much as > possible to close the obvious regressions but I guess we have to expect > there will be cases where the OOM fires and hasn't before and vice > versa. Aren't you forgetting that some people use panic_on_oom > 0 which means that premature OOM killer invocation is fatal for them?