Subject: Re: [RFC PATCH 4/4] mmc: sdhci-of-arasan: overwrite enhanced strobe
 callback
To: Shawn Lin <shawn.lin@rock-chips.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
References: <1456972557-7994-1-git-send-email-shawn.lin@rock-chips.com>
 <1456972613-8159-1-git-send-email-shawn.lin@rock-chips.com>
CC: Michal Simek <michal.simek@xilinx.com>, <soren.brinkmann@xilinx.com>,
        <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Michal Simek <michal.simek@xilinx.com>
Message-ID: <56D819C4.9080703@xilinx.com>
Date: Thu, 3 Mar 2016 12:02:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1456972613-8159-1-git-send-email-shawn.lin@rock-chips.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2016 11:02:34.2320
 (UTC)
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM02HT214
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1162
Lines: 32

On 3.3.2016 03:36, Shawn Lin wrote:
> Currently sdhci-arasan 5.1 can support enhanced strobe function,
> but considering the potential requirement in the future for other
> version IP, we don't limit it just for "arasan,sdhci-5.1". Add
> cap-enhanced-strobe in DT to enable the function if we'r sure our
> controller can support it.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> 
>  drivers/mmc/host/sdhci-of-arasan.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 1e4b5e0..31f3494 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -24,7 +24,9 @@
>  #include "sdhci-pltfm.h"
>  
>  #define SDHCI_ARASAN_CLK_CTRL_OFFSET	0x2c
> +#define SDHCI_ARASAN_VENDOR_REGISTER	0x78

I was checking our register map and we even don't have this register
listed as reserved.
It looks like that this will be related to certain SoC and different SoC
can use it different location.
That's why I think this feature and setup should be related to certain
SoC specific compatible string.

Thanks,
Michal