Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754554AbcCCM2E (ORCPT ); Thu, 3 Mar 2016 07:28:04 -0500 Received: from mail-ig0-f193.google.com ([209.85.213.193]:33712 "EHLO mail-ig0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976AbcCCM2A (ORCPT ); Thu, 3 Mar 2016 07:28:00 -0500 MIME-Version: 1.0 In-Reply-To: <2233190.1BxevBAvDE@wuerfel> References: <1456992221-26712-1-git-send-email-k.kozlowski@samsung.com> <1456992221-26712-9-git-send-email-k.kozlowski@samsung.com> <2233190.1BxevBAvDE@wuerfel> Date: Thu, 3 Mar 2016 13:27:59 +0100 X-Google-Sender-Auth: _v1grdaO1sNfPoiNreJaWjsm70E Message-ID: Subject: Re: [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on HAS_IOMEM From: Geert Uytterhoeven To: Arnd Bergmann Cc: "linux-arm-kernel@lists.infradead.org" , Krzysztof Kozlowski , Linus Walleij , "linux-kernel@vger.kernel.org" , David Brown , Alexandre Belloni , Laurent Pinchart , Lee Jones , Thomas Gleixner , driverdevel , "linux-samsung-soc@vger.kernel.org" , Vinod Koul , Daniel Lezcano , Kishon Vijay Abraham I , Andy Gross , Linux Media Mailing List , Jason Cooper , RTCLINUX , Mauro Carvalho Chehab , Marc Zyngier , "linux-arm-msm@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Giuseppe Cavallaro , Dan Williams , linux-soc@vger.kernel.org, Alessandro Zummo , Greg Kroah-Hartman , Linux PM list , USB list , Sebastian Reichel , Dmitry Eremin-Solenikov , "netdev@vger.kernel.org" , dmaengine@vger.kernel.org, David Woodhouse Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 33 On Thu, Mar 3, 2016 at 11:55 AM, Arnd Bergmann wrote: > On Thursday 03 March 2016 17:03:34 Krzysztof Kozlowski wrote: >> index 0da40e2e4280..5c530b6b125d 100644 >> --- a/drivers/rtc/Kconfig >> +++ b/drivers/rtc/Kconfig >> @@ -1302,6 +1302,7 @@ config RTC_DRV_AT91RM9200 >> config RTC_DRV_AT91SAM9 >> tristate "AT91SAM9 RTT as RTC" >> depends on ARCH_AT91 || COMPILE_TEST >> + depends on HAS_IOMEM # For MFD_SYSCON >> select MFD_SYSCON >> help >> Some AT91SAM9 SoCs provide an RTT (Real Time Timer) block which >> > > This is technically correct, but the entire RTC menu is hidden > inside of 'depends on !UML && !S390', so we won't ever get there > on any configuration that does not use HAS_IOMEM. > > If we did, all other RTC drivers would also fail. So UML has no RTC. Should/can it use RTC_DRV_GENERIC? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds