Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758052AbcCCOxx (ORCPT ); Thu, 3 Mar 2016 09:53:53 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:48755 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756802AbcCCOxu (ORCPT ); Thu, 3 Mar 2016 09:53:50 -0500 Date: Thu, 3 Mar 2016 15:53:48 +0100 From: Andrew Lunn To: Neil Armstrong Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings Message-ID: <20160303145348.GI15541@lunn.ch> References: <1457005210-18485-1-git-send-email-narmstrong@baylibre.com> <1457005210-18485-4-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457005210-18485-4-git-send-email-narmstrong@baylibre.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 26 On Thu, Mar 03, 2016 at 12:39:56PM +0100, Neil Armstrong wrote: > Signed-off-by: Neil Armstrong > --- > .../bindings/interrupt-controller/plxtech,rps-irq.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt > new file mode 100644 > index 0000000..db117a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt ... > +- compatible: Should be "plxtech,nas782x-rps" Hi Neil It would be nice to be consistent with the naming. Maybe also the filename of the driver itself should be changed. You had an interesting sorting problem in the Makefile, which a consistent name would help with. Andrew