Date: Thu, 3 Mar 2016 08:17:14 -0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: devel@driverdev.osuosl.org, Rob Clark <robdclark@gmail.com>,
        Daniel Stone <daniels@collabora.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Riley Andrews <riandrews@android.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Greg Hackmann <ghackmann@google.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        John Harrison <John.C.Harrison@Intel.com>
Subject: Re: [PATCH] staging/android: add flags member to sync ioctl structs
Message-ID: <20160303161714.GA4133@kroah.com>
References: <1456955489-18971-1-git-send-email-gustavo@padovan.org>
 <1457015837-7609-1-git-send-email-gustavo@padovan.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1457015837-7609-1-git-send-email-gustavo@padovan.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 638
Lines: 21

On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Play safe and add flags member to all structs. So we don't need to
> break API or create new IOCTL in the future if new features that requires
> flags arises.
> 
> v2: check if flags are valid (zero, in this case)
> 
> v3: return -EINVAL if flags are not zero'ed
> 
> v4: add padding for 64-bit alignment
> 
> v5: rebase to use only stacked sync_file_info

Why are these vX things here in the changelog?

And you just broke all existing userspace users of this code, why are
you allowed to do that?

not ok...