Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758175AbcCCR5k (ORCPT ); Thu, 3 Mar 2016 12:57:40 -0500 Received: from mail-vk0-f43.google.com ([209.85.213.43]:32979 "EHLO mail-vk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755942AbcCCR5i (ORCPT ); Thu, 3 Mar 2016 12:57:38 -0500 MIME-Version: 1.0 In-Reply-To: <1457000385-2317-2-git-send-email-drinkcat@chromium.org> References: <1457000385-2317-1-git-send-email-drinkcat@chromium.org> <1457000385-2317-2-git-send-email-drinkcat@chromium.org> Date: Thu, 3 Mar 2016 09:57:37 -0800 X-Google-Sender-Auth: vz4mxPQGnjoMY34Z2TAxTBET-Q0 Message-ID: Subject: Re: [PATCH 2/2] mmc: mediatek: Use mmc_regulator_set_vqmmc in start_signal_voltage_switch From: Doug Anderson To: Nicolas Boichat Cc: Ulf Hansson , Matthias Brugger , Chaotian Jing , Geert Uytterhoeven , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 27 Nicolas, On Thu, Mar 3, 2016 at 2:19 AM, Nicolas Boichat wrote: > We've introduced a new helper in the MMC core: > mmc_regulator_set_vqmmc(). Let's use this in mtk-sd. Using this new > helper has some advantages: > > 1. We get the mmc_regulator_set_vqmmc() behavior of trying to match > VQMMC and VMMC when the signal voltage is 3.3V. This ensures max > compatibility. > > 2. We get rid of a few more warnings when probing unsupported > voltages. > > 3. We get rid of some non-mediatek specific code in mtk-sd. > > Signed-off-by: Nicolas Boichat > --- > > Similar to e0848f5d294c703917260a6228cc08b8be46c527 > mmc: dw_mmc: Use mmc_regulator_set_vqmmc in start_signal_voltage_switch , > where I copied the commit message from. > > drivers/mmc/host/mtk-sd.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) Reviewed-by: Douglas Anderson