Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757901AbcCCTme (ORCPT ); Thu, 3 Mar 2016 14:42:34 -0500 Received: from mail-yw0-f170.google.com ([209.85.161.170]:33523 "EHLO mail-yw0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbcCCTmc (ORCPT ); Thu, 3 Mar 2016 14:42:32 -0500 Date: Thu, 3 Mar 2016 16:42:28 -0300 From: Gustavo Padovan To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Rob Clark , Daniel Stone , Daniel Vetter , Maarten Lankhorst , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Greg Hackmann , John Harrison Subject: Re: [PATCH] staging/android: add flags member to sync ioctl structs Message-ID: <20160303194228.GB2446@joana> Mail-Followup-To: Gustavo Padovan , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Rob Clark , Daniel Stone , Daniel Vetter , Maarten Lankhorst , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Greg Hackmann , John Harrison References: <1456955489-18971-1-git-send-email-gustavo@padovan.org> <1457015837-7609-1-git-send-email-gustavo@padovan.org> <20160303161714.GA4133@kroah.com> <20160303191432.GC2454@joana> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160303191432.GC2454@joana> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 28 2016-03-03 Gustavo Padovan : > Hi Greg, > > 2016-03-03 Greg Kroah-Hartman : > > > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Play safe and add flags member to all structs. So we don't need to > > > break API or create new IOCTL in the future if new features that requires > > > flags arises. > > > > > > v2: check if flags are valid (zero, in this case) > > > > > > v3: return -EINVAL if flags are not zero'ed > > > > > > v4: add padding for 64-bit alignment > > > > > > v5: rebase to use only stacked sync_file_info > > > > Why are these vX things here in the changelog? > > There are few people who does this in drm, so I just followed that. Anyway, I've sent v7 without the vX things in the changelog. Gustavo