Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755136AbcCCUcY (ORCPT ); Thu, 3 Mar 2016 15:32:24 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:47472 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752995AbcCCUcX (ORCPT ); Thu, 3 Mar 2016 15:32:23 -0500 From: Laurent Pinchart To: Kevin Hilman Cc: Laurent Pinchart , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Ulf Hansson Subject: Re: [PATCH] PM / Domains: Propagate start and restore errors during runtime resume Date: Thu, 03 Mar 2016 22:32:22 +0200 Message-ID: <1981850.MfupToJLYq@avalon> User-Agent: KMail/4.14.8 (Linux/4.1.15-gentoo-r1; KDE/4.14.8; x86_64; ; ) In-Reply-To: <7h60x3wbrc.fsf@baylibre.com> References: <1456874438-26330-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <7h60x3wbrc.fsf@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1507 Lines: 40 Hi Kevin, Thank you for the review. On Thursday 03 March 2016 12:24:23 Kevin Hilman wrote: > Laurent Pinchart writes: > > During runtime resume the return values of the start and restore steps > > are ignored. As a result drivers are not notified of runtime resume > > failures and can't propagate them up. Fix it by returning an error if > > either the start or restore step fails, and clean up properly in the > > error path. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/base/power/domain.c | 20 ++++++++++++++++++-- > > 1 file changed, 18 insertions(+), 2 deletions(-) > > > > This fixes an issue I've noticed with my driver's .runtime_resume() > > handler returning an error that was never propagated out of > > pm_runtime_get_sync(). > > Acked-by: Kevin Hilman > > > A second issue then appeared. The device .runtime_error field is set to > > the error code returned by my .runtime_resume() handler, but it never > > reset. Any subsequent try to resume the device fails with -EINVAL. I'm not > > sure what the right way to solve that is, advices are welcome. > > Probably setting it (back) to zero after each successful runtime_suspend > or runtime_resume is the right way. Rafael? It would if you could try resuming again after a failed attempt, but you'll receive an error immediately if you try with .runtime_error set. -- Regards, Laurent Pinchart